Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show a console message when using construct_clip() #487

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

wurli
Copy link
Contributor

@wurli wurli commented Sep 26, 2024

Closes #486

NB, I had some test failures when running locally, but I think they must be due to differences with my setup because they were all about where linebreaks are placed. Here's an example:

Failure ([test-s3-R6ClassGenerator.R:2:3](vscode-file://vscode-app/Applications/Positron.app/Contents/Resources/app/out/vs/code/electron-sandbox/workbench/workbench.html#)): R6Class
Snapshot of code has changed:
     old                                                        | new                                                  
[54]     ),                                                     |     ),                                           [54]
[55]     private = list(                                        |     private = list(                              [55]
[56]       queue = list(),                                      |       queue = list(),                            [56]
[57]       length = (function() base::length(private$queue)) |> -       length = (function() base::length(private$ [57]
                                                                -         queue)) |>                               [58]
[58]         (`environment<-`)(                                 |         (`environment<-`)(                       [59]
[59]           constructive::.env(                              |           constructive::.env(                    [60]
[60]             "0x123456789",                                 |             "0x123456789",                       [61]

I assume these won't show up in the CI tests. I'll investigate further when I get a chance.

Copy link
Contributor

aviator-app bot commented Sep 26, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@moodymudskipper
Copy link
Collaborator

Thanks! just a minor adjustment and it's good to go!

@wurli
Copy link
Contributor Author

wurli commented Sep 27, 2024

Nice :) What's the adjustment? One for me to make?

@moodymudskipper
Copy link
Collaborator

I had a couple comments in the review above, but I'll handle these on my side, thanks!

@moodymudskipper moodymudskipper merged commit 3ae5a4b into cynkra:main Dec 31, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Console message for construct_clip()?
2 participants