.invoke() no longer awaits promises in 11.x
#4785
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
3 tasks
chrisbreiding
approved these changes
Oct 18, 2022
flotwig
approved these changes
Oct 26, 2022
|
Folding this in with my main PR to the v12 branch. https://github.com/cypress-io/cypress-documentation/pull/4835/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matching code PR: cypress-io/cypress#24203
User-facing changelog:
I'm not adding an 11.0.0 Changelog file yet so that merging into the
v11branch later is a bit less painful; creating the changelog entries will be a TODO when mergingissue-7306intov11..invoke()no longer waits for promises to resolve. If you wish to await a promise, usecy.then()instead.cy.getCookie()fails to find a cookie, you can no longer traverse the non-existent cookie's properties (eg, with.its('value)). If you expect a cookie not to exist, assert that directly, eg:cy.getCookie('foo1').should('not.exist')