diff --git a/packages/data-context/src/data/ProjectConfigManager.ts b/packages/data-context/src/data/ProjectConfigManager.ts index 258ff7209fe9..2717bedc4fba 100644 --- a/packages/data-context/src/data/ProjectConfigManager.ts +++ b/packages/data-context/src/data/ProjectConfigManager.ts @@ -191,12 +191,6 @@ export class ProjectConfigManager { return } - const result = await isDependencyInstalled(bundler, this.options.projectRoot) - - if (!result.satisfied) { - unsupportedDeps.set(result.dependency.type, result) - } - const isFrameworkSatisfied = async (bundler: typeof WIZARD_BUNDLERS[number], framework: typeof WIZARD_FRAMEWORKS[number]) => { for (const dep of await (framework.dependencies(bundler.type, this.options.projectRoot))) { const res = await isDependencyInstalled(dep.dependency, this.options.projectRoot) diff --git a/packages/data-context/test/unit/sources/WizardDataSource.spec.ts b/packages/data-context/test/unit/sources/WizardDataSource.spec.ts index 334fe28c00c9..6bb6367d8877 100644 --- a/packages/data-context/test/unit/sources/WizardDataSource.spec.ts +++ b/packages/data-context/test/unit/sources/WizardDataSource.spec.ts @@ -27,7 +27,7 @@ describe('packagesToInstall', () => { const actual = await ctx.wizard.installDependenciesCommand() - expect(actual).to.eq(`npm install -D react-scripts webpack react-dom react`) + expect(actual).to.eq(`npm install -D react-scripts react-dom react`) }) it('vueclivue2-unconfigured', async () => { @@ -43,7 +43,7 @@ describe('packagesToInstall', () => { const actual = await ctx.wizard.installDependenciesCommand() - expect(actual).to.eq(`npm install -D @vue/cli-service webpack vue@2`) + expect(actual).to.eq(`npm install -D @vue/cli-service vue@2`) }) it('vueclivue3-unconfigured', async () => { @@ -59,7 +59,7 @@ describe('packagesToInstall', () => { const actual = await ctx.wizard.installDependenciesCommand() - expect(actual).to.eq(`npm install -D @vue/cli-service webpack vue`) + expect(actual).to.eq(`npm install -D @vue/cli-service vue`) }) it('vuecli5vue3-unconfigured', async () => { @@ -75,7 +75,7 @@ describe('packagesToInstall', () => { const actual = await ctx.wizard.installDependenciesCommand() - expect(actual).to.eq(`npm install -D @vue/cli-service webpack vue`) + expect(actual).to.eq(`npm install -D @vue/cli-service vue`) }) it('regular react project with vite', async () => { diff --git a/packages/launchpad/cypress/e2e/config-warning.cy.ts b/packages/launchpad/cypress/e2e/config-warning.cy.ts index 4e9c03348ef7..fc1d1e782638 100644 --- a/packages/launchpad/cypress/e2e/config-warning.cy.ts +++ b/packages/launchpad/cypress/e2e/config-warning.cy.ts @@ -187,4 +187,14 @@ describe('component testing dependency warnings', () => { cy.contains('Choose a Browser', { timeout: 12000 }) cy.get('[data-cy="warning-alert"]').should('not.exist') }) + + it('does not show warning for project that does not require bundler to be installed', () => { + cy.scaffoldProject('next-12') + cy.openProject('next-12') + cy.visitLaunchpad() + cy.get('[data-cy="warning-alert"]').should('not.exist') + cy.get('[data-cy-testingtype="component"]').click() + cy.contains('Choose a Browser', { timeout: 12000 }) + cy.get('[data-cy="warning-alert"]').should('not.exist') + }) }) diff --git a/packages/launchpad/cypress/e2e/project-setup.cy.ts b/packages/launchpad/cypress/e2e/project-setup.cy.ts index 597d6af1f3d2..b86ebc28267f 100644 --- a/packages/launchpad/cypress/e2e/project-setup.cy.ts +++ b/packages/launchpad/cypress/e2e/project-setup.cy.ts @@ -379,9 +379,9 @@ describe('Launchpad: Setup Project', () => { cy.findByRole('button', { name: 'Next Step' }).click() cy.findByRole('button', { name: 'Waiting for you to install the dependencies...' }) - cy.contains('li', 'webpack') cy.contains('li', 'react-scripts') cy.contains('li', 'react') + cy.contains('li', 'react-dom') cy.findByRole('button', { name: 'Skip' }).click() diff --git a/packages/scaffold-config/src/frameworks.ts b/packages/scaffold-config/src/frameworks.ts index f006d46ec69b..c99428f5fa92 100644 --- a/packages/scaffold-config/src/frameworks.ts +++ b/packages/scaffold-config/src/frameworks.ts @@ -86,7 +86,6 @@ export const WIZARD_FRAMEWORKS = [ dependencies: (bundler: WizardBundler['type'], projectPath: string): Promise => { return Promise.all([ isDependencyInstalled(dependencies.WIZARD_DEPENDENCY_REACT_SCRIPTS, projectPath), - isDependencyInstalled(dependencies.WIZARD_DEPENDENCY_WEBPACK, projectPath), isDependencyInstalled(dependencies.WIZARD_DEPENDENCY_REACT_DOM, projectPath), isDependencyInstalled(dependencies.WIZARD_DEPENDENCY_REACT, projectPath), ]) @@ -107,7 +106,6 @@ export const WIZARD_FRAMEWORKS = [ dependencies: (bundler: WizardBundler['type'], projectPath: string): Promise => { return Promise.all([ isDependencyInstalled(dependencies.WIZARD_DEPENDENCY_VUE_CLI_SERVICE, projectPath), - isDependencyInstalled(dependencies.WIZARD_DEPENDENCY_WEBPACK, projectPath), isDependencyInstalled(dependencies.WIZARD_DEPENDENCY_VUE_2, projectPath), ]) }, @@ -127,7 +125,6 @@ export const WIZARD_FRAMEWORKS = [ dependencies: (bundler: WizardBundler['type'], projectPath: string): Promise => { return Promise.all([ isDependencyInstalled(dependencies.WIZARD_DEPENDENCY_VUE_CLI_SERVICE, projectPath), - isDependencyInstalled(dependencies.WIZARD_DEPENDENCY_WEBPACK, projectPath), isDependencyInstalled(dependencies.WIZARD_DEPENDENCY_VUE_3, projectPath), ]) }, diff --git a/system-tests/__snapshots__/component_testing_spec.ts.js b/system-tests/__snapshots__/component_testing_spec.ts.js index ad7616d0ddd6..dcab2102a32e 100644 --- a/system-tests/__snapshots__/component_testing_spec.ts.js +++ b/system-tests/__snapshots__/component_testing_spec.ts.js @@ -533,13 +533,6 @@ exports['React major versions with Vite executes all of the tests for React v18 ` exports['experimentalSingleTabRunMode / executes all specs in a single tab'] = ` -We detected that you have versions of dependencies that are not officially supported: - - - \`webpack\`. Expected >=4.0.0 || >=5.0.0 but dependency was not found. - -If you're experiencing problems, downgrade dependencies and restart Cypress. - - 30 modules ==================================================================================================== diff --git a/system-tests/projects/experimentalSingleTabRunMode/webpack.config.js b/system-tests/projects/experimentalSingleTabRunMode/webpack.config.js index 4ba52ba2c8df..74edfc0c20e2 100644 --- a/system-tests/projects/experimentalSingleTabRunMode/webpack.config.js +++ b/system-tests/projects/experimentalSingleTabRunMode/webpack.config.js @@ -1 +1,3 @@ -module.exports = {} +module.exports = { + stats: 'errors-warnings', +}