From c884f946d65e1723b9f0d0a350ec0fe9cd003479 Mon Sep 17 00:00:00 2001 From: Jennifer Shehane Date: Wed, 2 Oct 2024 09:49:01 -0400 Subject: [PATCH] Revert "remove instruction to update electron version in centos 7 step" This reverts commit 01131cfecaab41acdc6b678fddf39515c2301889. --- packages/electron/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/electron/README.md b/packages/electron/README.md index 638c308bfaba..c1f2726384ca 100644 --- a/packages/electron/README.md +++ b/packages/electron/README.md @@ -47,6 +47,7 @@ Upgrading `electron` involves more than just bumping this package's `package.jso - The [NodeJS](https://nodejs.org/en) version is not the active LTS. - [ ] **Update `workflows.yml`** - [ ] Ensure it references the new `base-internal` and `browsers-internal` Docker images + - [ ] Ensure the new Electron version is used as a build target in the `Build better-sqlite3 for CentOS 7` step - [ ] **Ensure that a matching Node.js version is enforced in the monorepo for local development and CI.** When Electron is upgraded, oftentimes, the bundled Node.js version that comes with Electron is updated as well. Because all unit and integration tests run in normal Node.js (not Electron's Node.js), it's important for this Node.js version to be synced with the monorepo. There are a few places where this needs to be done: - [ ] [`/.node-version`](../../.node-version) - used by `nvm` and other Node version managers