-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detached DOM: Commands._addQuery() #23550
Milestone
Comments
This was referenced Aug 25, 2022
cypress-bot
bot
added
the
stage: needs review
The PR code is done & tested, needs review
label
Aug 30, 2022
BlueWinds
changed the title
Detached DOM: Commands.addSelector()
Detached DOM: Commands.addQuery()
Sep 7, 2022
BlueWinds
changed the title
Detached DOM: Commands.addQuery()
Detached DOM: Commands._addQuery()
Sep 26, 2022
This was reverted from |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
cypress-bot
bot
removed
the
stage: needs review
The PR code is done & tested, needs review
label
Oct 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What would you like?
As part of the Detached DOM work, we need to implement "queries", which are commands that function in a different way from existing cypress commands - they are synchronous, idempotent, and aren't responsible for their own retry loop.
I'm starting work with
.get()
and.as()
- these are some of the most complicated commands in Cypress (encompassing as they do "getting elements from the DOM" and aliases, which are strangely complex for a simple-sounding concept).Why is this needed?
Have to start somewhere. I started at the deep end, so that I can encounter any issues with my approach immediately rather than later in the process.
Other
This PR is again the
develop
branch - unlike the previous iteration of this work, it should be safe to release to users as-is (not a breaking change).The text was updated successfully, but these errors were encountered: