Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update remaining queries to use _addQuery() #23902

Closed
BlueWinds opened this issue Sep 20, 2022 · 1 comment
Closed

Update remaining queries to use _addQuery() #23902

BlueWinds opened this issue Sep 20, 2022 · 1 comment
Assignees
Labels
stage: needs review The PR code is done & tested, needs review

Comments

@BlueWinds
Copy link
Contributor

What would you like?

Following on from #23550 and #23804, we need to migrate the remaining commands that will be queries to use the new API. The remaining list is:

.children()
.closest()
.debug()
.document()
.eq()
.filter()
.first()
.focused()
.getCookie()
.getCookies()
.hash()
.invoke()
.its()
.last()
.location()
.next()
.nextAll()
.nextUntil()
.not()
.parent()
.parents()
.parentsUntil()
.pause()
.prev()
.prevAll()
.prevUntil()
.siblings()
.title()
.url()
.window()

While this looks like quite a huge list, the process is quite quick for most command -> query migrations, and in particular many of these are simply aliases - .last(), .first(), .next() etc are all defined in the same file and use the same logic underneath the hood.

Why is this needed?

No response

Other

No response

@BlueWinds
Copy link
Contributor Author

Completed in #24203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stage: needs review The PR code is done & tested, needs review
Projects
None yet
Development

No branches or pull requests

1 participant