Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing CI information from GitLab #6231

Closed
TomaszG opened this issue Jan 23, 2020 · 4 comments · Fixed by #6561
Closed

Missing CI information from GitLab #6231

TomaszG opened this issue Jan 23, 2020 · 4 comments · Fixed by #6561

Comments

@TomaszG
Copy link
Contributor

TomaszG commented Jan 23, 2020 •
edited
Loading

It seems that the project URL and default branch are not utilized correctly by the runner. Due to this, some 3rd party tools may not work properly when they expect remoteOrigin and defaultBranch in commitParams for runs recorded by Cypress running as GitLab job.
@TomaszG TomaszG mentioned this issue Jan 23, 2020
Closed
@jennifer-shehane
Copy link
Member

jennifer-shehane commented Jan 24, 2020 •
edited
Loading

When opening an issue, please fill out the issue template provided - it requires necessary information we need to help you, like desired behavior, a reproducible example and the version of Cypress you are using.

Please include a screenshot of the area you're mentioning with the 'Default branch' and the 'project URL' that is specifically missing.

This issue will be closed as per our contributing guidelines. Please comment in this issue with the required information from our issue template and we will reopen the issue.

@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: work in progress and removed stage: work in progress stage: needs review The PR code is done & tested, needs review labels Feb 14, 2020
@cypress-bot cypress-bot bot added stage: ready for work The issue is reproducible and in scope and removed stage: work in progress labels Feb 26, 2020
@TomaszG TomaszG mentioned this issue Feb 26, 2020
Merged
1 task
@cypress-bot cypress-bot bot added stage: work in progress and removed stage: ready for work The issue is reproducible and in scope labels Feb 26, 2020
@TomaszG
Copy link
Contributor Author

TomaszG commented Feb 26, 2020

@jennifer-shehane I have updated the first message in the discussion, also please see my comment in related PR.

@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Feb 26, 2020
jennifer-shehane pushed a commit that referenced this issue Feb 27, 2020
@TomaszG
Issue 6231 use more information from gitlab (#6561)
9a78515 
* #6231 use more CI information from GitLab

* issue-6231 fix spec provider tests

* issue-6231 use GitLab CI Repository URL instead of Project URL as remoteOrigin commit param
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 27, 2020

The code for this is done in cypress-io/cypress#6561, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot removed the stage: needs review The PR code is done & tested, needs review label Feb 27, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 28, 2020

Released in 4.1.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.1.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 6231 use more information from gitlab
#6231 use more CI information from GitLab
2 participants
@TomaszG @jennifer-shehane