Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a toggle to close/open all folders in Tests list #6282

Closed
Mat-Longinow opened this issue Jan 31, 2020 · 5 comments · Fixed by #6541
Closed

Create a toggle to close/open all folders in Tests list #6282

Mat-Longinow opened this issue Jan 31, 2020 · 5 comments · Fixed by #6541
Labels
good first issue Good for newcomers pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory type: enhancement Requested enhancement of existing feature

Comments

@Mat-Longinow
Copy link

Mat-Longinow commented Jan 31, 2020 •
edited
Loading

Current Behavior:
Currently there seems to be no way to have all your folders defaulted to close when you open up Cypress.

The results is a messy UI that isn't as clean when you try and organize your many Cypress tests into folders.

Desired Behavior:
Have a setting option to default your folders to close on Cypress open that way you can navigate a cleaner interface when you organize your multiple tests into their appropriate folders.

Screen Shot 2020-01-30 at 4 46 20 PM
@jennifer-shehane
Copy link
Member

jennifer-shehane commented Feb 4, 2020 •
edited
Loading

I would suggest adding something in the interface to click to collapse all folders to satisfy your needs. We would be open to a PR for this.

Saving this as project state or global state would be trickier. Although we are working on interfaces for more configurable 'global' settings from within the UI, this would be a very low priority for us.

specs list code: https://github.com/cypress-io/cypress/blob/develop/packages/desktop-gui/src/specs/specs-list.jsx#L15:L15
specs tests code: https://github.com/cypress-io/cypress/blob/develop/packages/desktop-gui/cypress/integration/specs_list_spec.js

@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Feb 4, 2020
@jennifer-shehane jennifer-shehane changed the title Feature Request: Create toggle in settings to default folders to closed in Cypress interface Create a toggle to close/open all folders in Tests list Feb 4, 2020
@jennifer-shehane jennifer-shehane added type: enhancement Requested enhancement of existing feature pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory priority: low 🎗 good first issue Good for newcomers labels Feb 4, 2020
@netochaves
Copy link
Contributor

Can I take this?

@sabina-rohman
Copy link

Hi, I am new to open source contributions. Please, assign it to me if it's not assigned to anybody. Thanks.

martinsik pushed a commit to martinsik/cypress that referenced this issue Feb 24, 2020
desktop-gui: add toggle buttons to expand/collapse all sub folders. c…
d90ae85 
…ypress-io#6282
@martinsik martinsik mentioned this issue Feb 24, 2020
Merged
5 tasks
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope stage: work in progress stage: needs review The PR code is done & tested, needs review labels Feb 24, 2020
jennifer-shehane added a commit that referenced this issue Feb 28, 2020
@martinsik @chrisbreiding @jennifer-shehane
desktop-gui: Add toggle buttons to root specs to expand/collaps… (#6541)
d7d5e22 
* desktop-gui: add toggle buttons to expand/collapse all sub folders. #6282

* lint code changes

* hide collapse/expand buttons when root spec has no folders

* fix indentation

* fix lint issue and refactor a bit

* Move collapse/expand links to right side of folder header

Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 28, 2020

The code for this is done in cypress-io/cypress#6541, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot removed the stage: needs review The PR code is done & tested, needs review label Feb 28, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 28, 2020

Released in 4.1.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.1.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory type: enhancement Requested enhancement of existing feature
Projects
None yet
Milestone
No milestone
4 participants
@jennifer-shehane @Mat-Longinow @netochaves @sabina-rohman