Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect type definition for isBrowser #6447

Closed
kuceb opened this issue Feb 13, 2020 · 2 comments · Fixed by #6448
Closed

incorrect type definition for isBrowser #6447

kuceb opened this issue Feb 13, 2020 · 2 comments · Fixed by #6448
Labels
v4.0.0 🐛 Issue present since 4.0.0

Comments

@kuceb
Copy link
Contributor

kuceb commented Feb 13, 2020 •
edited
Loading

isBrowser accepts a matcher object as well as a browser name
@kuceb kuceb added the v4.0.0 🐛 Issue present since 4.0.0 label Feb 13, 2020
@kuceb kuceb mentioned this issue Feb 13, 2020
Merged
3 tasks
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: work in progress stage: needs review The PR code is done & tested, needs review labels Feb 13, 2020
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Feb 13, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 13, 2020

The code for this is done in cypress-io/cypress#6448, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 14, 2020

Released in 4.0.2.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.0.2, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Feb 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
v4.0.0 🐛 Issue present since 4.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: typedefs for isBrowser cypress-io/cypress
1 participant
@kuceb