Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Queries, Detached DOM, and Retry-Ability #24628

Merged
merged 51 commits into from
Nov 14, 2022
Merged

Commits on Sep 1, 2022

  1. Configuration menu
    Copy the full SHA
    0cc8b88 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0379058 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. Configuration menu
    Copy the full SHA
    fc1bdb2 View commit details
    Browse the repository at this point in the history
  2. Fix for failed tests

    BlueWinds committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    e0ebba5 View commit details
    Browse the repository at this point in the history
  3. Last test fix

    BlueWinds committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    b9be83b View commit details
    Browse the repository at this point in the history
  4. More test fixes

    BlueWinds committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    c4de5d9 View commit details
    Browse the repository at this point in the history
  5. Self review changes

    BlueWinds committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    518bd72 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. Configuration menu
    Copy the full SHA
    e33e29f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1876e83 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    789f71b View commit details
    Browse the repository at this point in the history
  4. Quick fix for last commit

    BlueWinds committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    3857845 View commit details
    Browse the repository at this point in the history
  5. Fix TS

    BlueWinds committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    a52b361 View commit details
    Browse the repository at this point in the history
  6. Fix merge from develop

    BlueWinds committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    2ffa3c5 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2022

  1. Configuration menu
    Copy the full SHA
    661c305 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0009d3c View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2022

  1. Configuration menu
    Copy the full SHA
    443b636 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'issue-7306-addSelector-redux' of github.com:cypress-io/…

    …cypress into issue-7306-addSelector-redux
    BlueWinds committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    caff894 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2022

  1. Configuration menu
    Copy the full SHA
    ef57371 View commit details
    Browse the repository at this point in the history
  2. Fix typo in previous commit

    BlueWinds committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    f9da4bb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5d6e930 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2022

  1. Configuration menu
    Copy the full SHA
    98042e8 View commit details
    Browse the repository at this point in the history
  2. Fix TS

    BlueWinds committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    5ce6250 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    14aa153 View commit details
    Browse the repository at this point in the history
  4. Fix for previous commit

    BlueWinds committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    1b4ebb8 View commit details
    Browse the repository at this point in the history
  5. Review feedback

    BlueWinds committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    cd263af View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7a88624 View commit details
    Browse the repository at this point in the history
  7. Minor test improvement

    BlueWinds committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    dd05b4f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1ec423c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    ec4a682 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    514233a View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2022

  1. Configuration menu
    Copy the full SHA
    5a2db61 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2022

  1. Configuration menu
    Copy the full SHA
    9263b69 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    233c269 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8e9fda8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    31b0661 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2022

  1. Configuration menu
    Copy the full SHA
    5731717 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0267ebe View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2022

  1. Configuration menu
    Copy the full SHA
    8069e4f View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. Configuration menu
    Copy the full SHA
    555ed23 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. feat: move .contains() and .shadow() to be queries; remove cy.ng() (#…

    …23791)
    
    * First stab at removing old .get() implementation
    
    * Fix TS and a couple of tests
    
    * Fix tests and TS
    
    * Fix case-sensitivity for .contains()
    
    * Stop TS complaining
    
    * Rework cy-contains jquery expression
    
    * Add comments, make ts happy
    
    * Fix one test, review feedback
    
    * Review updates
    
    * Fix additional tests
    
    * Fix accidental deletion of vital code
    
    * One more try at getting logs right
    
    * Fix race condition in cross-origin .contains
    
    * Add commented out test to ensure .within() works properly with selectors
    
    * Fix for sessions + query subject chaining
    
    * Fix mixing .within() shadow DOM and .contains() in same chainer
    
    * One more attempt at .within + .contains
    
    * Fix rebase commits
    Blue F committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    2326f96 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9d2c02e View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. Configuration menu
    Copy the full SHA
    4038b8b View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2022

  1. Configuration menu
    Copy the full SHA
    989baec View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2022

  1. Configuration menu
    Copy the full SHA
    97e0e38 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. feat: addQuery Remaining Queries (#24203)

    * First stab at removing old .get() implementation
    
    * Fix TS and a couple of tests
    
    * Fix tests and TS
    
    * Fix case-sensitivity for .contains()
    
    * Stop TS complaining
    
    * Rework cy-contains jquery expression
    
    * Add comments, make ts happy
    
    * Fix one test, review feedback
    
    * Review updates
    
    * Fix additional tests
    
    * Fix accidental deletion of vital code
    
    * One more try at getting logs right
    
    * Fix race condition in cross-origin .contains
    
    * Add commented out test to ensure .within() works properly with selectors
    
    * Fix for sessions + query subject chaining
    
    * Fix mixing .within() shadow DOM and .contains() in same chainer
    
    * One more attempt at .within + .contains
    
    * Fix rebase commits
    
    * Update many commands to be queries; improve log message around invalid subjects
    
    * Update connectors, location, focused and window commands to queries
    
    * Return noop to a command and not a query (to avoid implicit assertions)
    
    * More test fixes
    
    * Fix test failures
    
    * Fix for weird-ass frontend-component test
    
    * Error message improvements
    
    * Fix for broken system test
    
    * Update withinSubject to use subject chain
    
    * Test clarifications
    
    * Unbreak cypress-testing-library via withinState backwards compatibility
    
    * Typo in last commit
    
    * Improvement for assertion following failed traversal
    Blue F committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    a052842 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2022

  1. Configuration menu
    Copy the full SHA
    2e35f2a View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2022

  1. feat: Fix detached DOM errors for all Cypress commands (#24417)

    * First stab at removing old .get() implementation
    
    * Fix TS and a couple of tests
    
    * Fix tests and TS
    
    * Fix case-sensitivity for .contains()
    
    * Stop TS complaining
    
    * Rework cy-contains jquery expression
    
    * Add comments, make ts happy
    
    * Fix one test, review feedback
    
    * Review updates
    
    * Fix additional tests
    
    * Fix accidental deletion of vital code
    
    * One more try at getting logs right
    
    * Fix race condition in cross-origin .contains
    
    * Add commented out test to ensure .within() works properly with selectors
    
    * Fix for sessions + query subject chaining
    
    * Fix mixing .within() shadow DOM and .contains() in same chainer
    
    * One more attempt at .within + .contains
    
    * Fix rebase commits
    
    * Update many commands to be queries; improve log message around invalid subjects
    
    * Update connectors, location, focused and window commands to queries
    
    * Return noop to a command and not a query (to avoid implicit assertions)
    
    * More test fixes
    
    * Fix test failures
    
    * Fix for weird-ass frontend-component test
    
    * Error message improvements
    
    * Fix for broken system test
    
    * Update withinSubject to use subject chain
    
    * Test clarifications
    
    * Unbreak cypress-testing-library via withinState backwards compatibility
    
    * Typo in last commit
    
    * Improvement for assertion following failed traversal
    
    * WIP adding query support to
    
    * More work on actionability + detached dom
    
    * Fix TS, rename _addQuery to addQuery
    
    * Another try to fix types
    
    * Fix lint
    
    * Fix for bad merge
    
    * Fixes for a couple more tests
    
    * Increase timeout 50ms -> 100ms on certain tests failing in CI
    
    * Switch to new branch of cypress-testing-library
    
    * Update lockfile
    
    * Fix yarn.lock with latest version of forked testing-library
    
    * More test fixes
    
    * Fix TS again
    
    * Increase test assertion timeout so it passes on slow browsers (webkit)
    
    * Apply suggestions from code review
    
    Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
    Co-authored-by: Zach Bloomquist <git@chary.us>
    
    * More review changes
    
    * Fix selectFile tests based on updated error message
    
    * Improve types and type comments for Commands.add
    
    * Undo change to Commands.add types
    
    * Update yarn lockfiles again
    
    * Remove overwriteQuery from Cy12; .focused() now respects passed in timeout
    
    * Update cli/types/cypress.d.ts
    
    Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
    
    * Restore .uncheck() tests
    
    Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
    Co-authored-by: Zach Bloomquist <git@chary.us>
    Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
    4 people committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    45953f7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9d2e8af View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b1518a6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    17003e9 View commit details
    Browse the repository at this point in the history
  5. Fix for app component test

    BlueWinds committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    9c2f198 View commit details
    Browse the repository at this point in the history