Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change cy.end() back to a command instead of a query #24681

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

BlueWinds
Copy link
Contributor

User facing changelog

No user-facing changes.

Additional details

Fix for issue introduced as part of #24628.

We want .end() not to be a query. This is because:

cy.get('button').end().get('button')

should end with a subject chain of [null, get('button')] and not [get('button'), end(), get('button')]. We want .end() to cut things off (which non-query commands do).

Steps to test

How has the user experience changed?

PR Tasks

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 14, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Nov 14, 2022



Test summary

21414 0 1802 0Flakiness 6


Run details

Project cypress
Status Passed
Commit 280dfee
Started Nov 14, 2022 5:22 PM
Ended Nov 14, 2022 5:40 PM
Duration 18:07 💡
OS Linux Debian -
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

top-nav-launchpad.cy.ts Flakiness
1 ... > global mode > shows "continue" button after login if project selected
commands/waiting.cy.js Flakiness
1 ... > timeouts > sets custom responseTimeout
2 ... > errors > throws waiting for the 3rd response
3 ... > errors > throws waiting for the 3rd response
specs_list_latest_runs.cy.ts Flakiness
1 App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs
This comment includes only the first 5 flaky tests. See all 6 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@mjhenkes mjhenkes merged commit cc63b13 into release/12.0.0 Nov 14, 2022
@mjhenkes mjhenkes deleted the issue-7306-end-command branch November 14, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants