Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address #3069 by using chokidar fs events #4038

Merged
merged 3 commits into from
May 7, 2019

Conversation

pauledwin
Copy link
Contributor

@pauledwin pauledwin commented Apr 26, 2019

Closes #3069

Globbing for spec changes on a large codebase may take longer than the hard-coded interval of 2500ms, as specified in #3069

Using fs events from chokidar partially addresses this problem by only scanning for spec changes when the watcher sees changes, rather than polling.

#3069 (comment)

@CLAassistant
Copy link

CLAassistant commented Apr 26, 2019

CLA assistant check
All committers have signed the CLA.

@lukeapage
Copy link
Contributor

@chrisbreiding any chance you can review this? I’d love to see it make 3.3.0 since it solves a daily drag for all our developers.

@lukeapage
Copy link
Contributor

@jennifer-shehane we are paying subscribers, is there a chance this Pr can be reviewed?

@chrisbreiding
Copy link
Contributor

@lukeapage It's my next priority to take a look at this. We should be able to get it out with 3.3.0

the watchers lib watches for file contents changing and doesn’t watch for files being added or removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screenshots can be very slow
4 participants