desktop-gui: Add toggle buttons to root specs to expand/collapse all their subfolders

[martinsik]

• Closes Create a toggle to close/open all folders in Tests list #6282

User facing changelog

There is now "collapse all" and "expand all" buttons in the Test Runner's 'Tests' tab to collapse or expand all folders within the integrationFolder .

How has the user experience changed?

This PR adds two buttons to UI next to each root spec name. Clicking "Collapse all" will only collapse subfolders and will keep the root spec expanded.

Collapse All / Expand All

Collapse All /Expand All links not shown when no folders

PR Tasks

• Have tests been added/updated?
• Has the original issue been tagged with a release in ZenHub?
• Has a PR for user-facing changes been opened in cypress-documentation?
• Have API changes been updated in the type definitions?
• Have new configuration options been added to the cypress.schema.json?

[cypress-bot]

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

• Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
• Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

• The feature/bugfix is self-documenting from within the product.
• The change provides the end user with a way to fix their problem (no dead ends).

Functionality

• The code works and performs its intended function with the correct logic.
• Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
• The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

• The code is readable (too many nested 'if's are a bad sign).
• Names used for variables, methods, etc, clearly describe their function.
• The code is easy to understood and there are relevant comments explaining.
• New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
• There are comments containing link(s) to the addressed issue (in tests and code).

Quality

• The change does not reimplement code.
• There's not a module from the ecosystem that should be used instead.
• There is no redundant or duplicate code.
• There are no irrelevant comments left in the code.
• Tests are testing the code’s intended functionality in the best way possible.

Internal

• The original issue has been tagged with a release in ZenHub.

[claassistantio]

All committers have signed the CLA.

[martinsik]

I'm not sure why there are two failing tests in commands/xhr_spec.coffee and commands/angular_spec.coffee.

[jennifer-shehane]

I think the collapse all | expand all links should be removed if there are no folders to expand/collapse, otherwise if just seems like the links don't do anything and is more clutter for users that don't have a larger test suite.

[jennifer-shehane]

@martinsik Some linting errors need fixing. You can run yarn lint-fix in the root of the project to automatically fix these before committing.

[martinsik]

@jennifer-shehane I tried running yarn lint-fix but it went through the whole project.

The lint check is now throwing:

/root/cypress/packages/desktop-gui/src/specs/specs-store.js
  146:16  error  'child' is defined but never used  no-unused-vars

But that's on this line which is weird.

https://github.com/cypress-io/cypress/pull/6541/files#diff-2bf56b7e7d242f95dffdd2309a9f2948R145-R152

It might be related to this: eslint/eslint#12165

addressed

[jennifer-shehane]

Final cosmetic change after asking team - wanted to move the 'collapse/expand' buttons to the right to clean up the UI clutter some.

[gunslingor]

What's the status of this? We have thousands of cy files in many folders, sure would be nice to collapse so we can see structure. An alternative would be to turn it into a table with path field and all column filter.

[martinsik]

@gunslingor This PR was merged a while ago into the old UI. I guess it was rewritten from scratch or redesigned heavily, so even though this PR was merged it's probably not relevant any more.