improve query speed when does not enable caching (grafana#2645)

* improve query speed when does not enable caching Signed-off-by: storyicon <storyicon@foxmail.com> * Update pkg/chunk/cache/tiered.go Co-authored-by: Ganesh Vernekar <15064823+codesome@users.noreply.github.com> Signed-off-by: storyicon <storyicon@foxmail.com> * simplify optimization Signed-off-by: storyicon <storyicon@foxmail.com> Co-authored-by: Ganesh Vernekar <15064823+codesome@users.noreply.github.com>
cyriltovena · Jun 4, 2020 · 27f38a7 · 27f38a7
1 parent f9bd0fd
commit 27f38a7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/cache/tiered.go b/cache/tiered.go
@@ -13,6 +13,12 @@ func NewTiered(caches []Cache) Cache {
 	return tiered(caches)
 }
 
+// IsEmptyTieredCache is used to determine whether the current Cache is implemented by an empty tiered.
+func IsEmptyTieredCache(cache Cache) bool {
+	c, ok := cache.(tiered)
+	return ok && len(c) == 0
+}
+
 func (t tiered) Store(ctx context.Context, keys []string, bufs [][]byte) {
 	for _, c := range []Cache(t) {
 		c.Store(ctx, keys, bufs)

diff --git a/storage/caching_index_client.go b/storage/caching_index_client.go
@@ -49,7 +49,7 @@ type cachingIndexClient struct {
 }
 
 func newCachingIndexClient(client chunk.IndexClient, c cache.Cache, validity time.Duration, limits StoreLimits) chunk.IndexClient {
-	if c == nil {
+	if c == nil || cache.IsEmptyTieredCache(c) {
 		return client
 	}