Skip to content
This repository has been archived by the owner on Sep 12, 2022. It is now read-only.

Remove traces of USE_ALLOCATION_SOURCES #790

Merged

Conversation

cdosborn
Copy link
Contributor

@cdosborn cdosborn commented Sep 4, 2018

Description

Remove traces of USE_ALLOCATION_SOURCES. This variable allowed us to transition from the old allocation system to the new one. We no longer use the old one and can remove all the conditional logic.

Checklist before merging Pull Requests

@cdosborn cdosborn force-pushed the remove-unused-use-allocation-sources-var branch from 8448b4b to 06b146f Compare September 4, 2018 17:19
@cdosborn cdosborn force-pushed the remove-unused-use-allocation-sources-var branch from 06b146f to 1ffcbe4 Compare September 4, 2018 17:22
@cdosborn cdosborn self-assigned this Sep 4, 2018
@cdosborn cdosborn requested review from c-mart and removed request for Tharon-C September 5, 2018 17:11
@cdosborn
Copy link
Contributor Author

cdosborn commented Sep 5, 2018

@Tharon-C, i'm adding @c-mart since he reviewed the secrets prs, and is already familiar

Copy link
Contributor

@c-mart c-mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not the right person to green-light this one (not familiar enough with Troposphere to understand the code changes), but the aim makes sense given the environment-specific PRs.

@cdosborn
Copy link
Contributor Author

cdosborn commented Sep 5, 2018

I forgot that there were more changes than just removing a variable

Copy link
Contributor

@Tharon-C Tharon-C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested locally, all of the removed branch logic returns the correct way and is formatted.
Thanks @cdosborn! 👍

@cdosborn cdosborn merged commit 2be08b7 into cyverse:master Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants