Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The MicromanagerOmeTiffReader needs better definitions or documentation for position attributes #152

Closed
ieivanov opened this issue Jun 21, 2023 · 1 comment · Fixed by #222
Closed

The MicromanagerOmeTiffReader needs better definitions or documentation for position attributes #152

ieivanov opened this issue Jun 21, 2023 · 1 comment · Fixed by #222
Labels
documentation Improvements or additions to documentation enhancement New feature or request μManager Micro-Manager files and metadata
Milestone
0.2.0

Comments

@ieivanov
Copy link
Contributor

The MicromanagerOmeTiffReader provides positions, stage_positions, position_arrays, and get_num_positions attributes / methods. We need better definition and/or documentation for these. Some (like position_arrays) should probably be internal and others (like get_num_positions which returns self.positions) should probably be deprecated.
@ziw-liu
Copy link
Collaborator

ziw-liu commented Jun 22, 2023

We should fix this during the upcoming UAPI refactor of the readers.

@ziw-liu ziw-liu added enhancement New feature or request μManager Micro-Manager files and metadata documentation Improvements or additions to documentation labels Jun 22, 2023
@ziw-liu ziw-liu mentioned this issue Feb 8, 2024
Merged
9 tasks
@ziw-liu ziw-liu added this to the 0.2.0 milestone Mar 4, 2024
@ziw-liu ziw-liu linked a pull request Jun 12, 2024 that will close this issue
Unified API for Micro-manager readers #222
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request μManager Micro-Manager files and metadata
Projects
None yet
Milestone
0.2.0
Development

Successfully merging a pull request may close this issue.

Unified API for Micro-manager readers czbiohub-sf/iohub
2 participants
@ieivanov @ziw-liu