-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force unwrap crash in Bot.init (JSON contains an error) #274
Comments
Interesting, this looks like a genuine error in XcodeServerSDK. Could you please provide more details on the response that you received? The error code? The JSON contents? It looks like we got 200 OK, with a JSON payload, but the contents were an error instead of Bot contents. So I need as much info as possible to be able to detect this earlier in the call, thanks! 😊 |
If the crash re-occurs, I will definitely get more data. So far, it has not recurred. |
I ended up moving to error propagation with #281, so now Buildasaur shouldn't crash anymore if it can't find an expected key in a received JSON. Please report if you still see this, now it'll just be a syncer error being printed out and shown in the UI. |
Sounds good. It has only happened once so far. On Fri, Jun 17, 2016 at 7:23 AM, Honza Dvorsky notifications@github.com
|
@ BuildaUtils/JSON.swift:: L#74
Context parameters::
Stack Trace::
The text was updated successfully, but these errors were encountered: