Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for repo URLs prefixed with ssh:// #260

Merged
merged 1 commit into from
May 10, 2016

Conversation

voidrender
Copy link
Contributor

From the Git Book:

To clone a Git repository over SSH, you can specify ssh:// URL like this:

$ git clone ssh://user@server/project.git

Or you can use the shorter scp-like syntax for the SSH protocol:

$ git clone user@server:project.git

Instead of depending on the url to start with "git@", the checkout type and git service are now determined using NSURL's resourceSpecifier and scheme properties without manipulating the original URL string.

I just noticed that there are small changes to the parse function in #251, but the merge shouldn't be tricky.

@buildasaur
Copy link
Collaborator

Result of Integration 1

Duration: 5 minutes and 39 seconds
Result: All 50 tests passed, but please fix 1 warning.

@czechboy0
Copy link
Member

Very cool, thanks for fixing it properly and even adding tests! 💯 👍

@czechboy0 czechboy0 merged commit a7f1558 into buildasaurs:master May 10, 2016
@voidrender voidrender deleted the improved-repo-url-parsing branch May 10, 2016 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants