This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
chore(deps): update dependency urllib3 to v1.26.19 [security] #3345
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
==1.24.1
->==1.26.19
Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
GitHub Vulnerability Alerts
CVE-2020-26137
urllib3 before 1.25.9 allows CRLF injection if the attacker controls the HTTP request method, as demonstrated by inserting CR and LF control characters in the first argument of
putrequest()
. NOTE: this is similar to CVE-2020-26116.CVE-2019-11236
In the urllib3 library through 1.24.2 for Python, CRLF injection is possible if the attacker controls the request parameter.
CVE-2023-43804
urllib3 doesn't treat the
Cookie
HTTP header special or provide any helpers for managing cookies over HTTP, that is the responsibility of the user. However, it is possible for a user to specify aCookie
header and unknowingly leak information via HTTP redirects to a different origin if that user doesn't disable redirects explicitly.Users must handle redirects themselves instead of relying on urllib3's automatic redirects to achieve safe processing of the
Cookie
header, thus we decided to strip the header by default in order to further protect users who aren't using the correct approach.Affected usages
We believe the number of usages affected by this advisory is low. It requires all of the following to be true to be exploited:
Cookie
header on requests, which is mostly typical for impersonating a browser.Remediation
redirects=False
when sending requests.Cookie
header.CVE-2018-25091
urllib3 before 1.24.2 does not remove the authorization HTTP header when following a cross-origin redirect (i.e., a redirect that differs in host, port, or scheme). This can allow for credentials in the authorization header to be exposed to unintended hosts or transmitted in cleartext. NOTE: this issue exists because of an incomplete fix for CVE-2018-20060 (which was case-sensitive).
CVE-2023-45803
urllib3 previously wouldn't remove the HTTP request body when an HTTP redirect response using status 303 "See Other" after the request had its method changed from one that could accept a request body (like
POST
) toGET
as is required by HTTP RFCs. Although the behavior of removing the request body is not specified in the section for redirects, it can be inferred by piecing together information from different sections and we have observed the behavior in other major HTTP client implementations like curl and web browsers.From RFC 9110 Section 9.3.1:
Affected usages
Because the vulnerability requires a previously trusted service to become compromised in order to have an impact on confidentiality we believe the exploitability of this vulnerability is low. Additionally, many users aren't putting sensitive data in HTTP request bodies, if this is the case then this vulnerability isn't exploitable.
Both of the following conditions must be true to be affected by this vulnerability:
Remediation
You can remediate this vulnerability with any of the following steps:
redirects=False
.redirects=False
and handle 303 redirects manually by stripping the HTTP request body.CVE-2024-37891
When using urllib3's proxy support with
ProxyManager
, theProxy-Authorization
header is only sent to the configured proxy, as expected.However, when sending HTTP requests without using urllib3's proxy support, it's possible to accidentally configure the
Proxy-Authorization
header even though it won't have any effect as the request is not using a forwarding proxy or a tunneling proxy. In those cases, urllib3 doesn't treat theProxy-Authorization
HTTP header as one carrying authentication material and thus doesn't strip the header on cross-origin redirects.Because this is a highly unlikely scenario, we believe the severity of this vulnerability is low for almost all users. Out of an abundance of caution urllib3 will automatically strip the
Proxy-Authorization
header during cross-origin redirects to avoid the small chance that users are doing this on accident.Users should use urllib3's proxy support or disable automatic redirects to achieve safe processing of the
Proxy-Authorization
header, but we still decided to strip the header by default in order to further protect users who aren't using the correct approach.Affected usages
We believe the number of usages affected by this advisory is low. It requires all of the following to be true to be exploited:
Proxy-Authorization
header without using urllib3's built-in proxy support.Remediation
Proxy-Authorization
header with urllib3'sProxyManager
.redirects=False
when sending requests.Proxy-Authorization
header.Release Notes
urllib3/urllib3 (urllib3)
v1.26.19
Compare Source
====================
Proxy-Authorization
header to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set viaRetry.remove_headers_on_redirect
.#​3405 <https://github.com/urllib3/urllib3/issues/3405>
__)v1.26.18
Compare Source
====================
v1.26.17
Compare Source
====================
Cookie
header to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set viaRetry.remove_headers_on_redirect
. (#​3139 <https://github.com/urllib3/urllib3/pull/3139>
_)v1.26.16
Compare Source
====================
PoolManager
with many distinct originswould cause connection pools to be closed while requests are in progress (
#​2954 <https://github.com/urllib3/urllib3/pull/2954>
_)v1.26.15
Compare Source
====================
HTTPConnection
is reused (#​2645 <https://github.com/urllib3/urllib3/issues/2645>
__)(
#​2899 <https://github.com/urllib3/urllib3/issues/2899>
__)#​2901 <https://github.com/urllib3/urllib3/issues/2901>
__)v1.26.14
Compare Source
====================
#​2850 <https://github.com/urllib3/urllib3/issues/2850>
__)PoolKey.key_retries
by addingbool
to the union. (#​2865 <https://github.com/urllib3/urllib3/issues/2865>
__)v1.26.13
Compare Source
====================
HTTPResponse.getheaders()
andHTTPResponse.getheader()
methods.even when the port number after removing the zeroes was valid.
<4
in theRequires-Python
packaging metadata field.v1.26.12
Compare Source
====================
urllib3[secure]
extra and theurllib3.contrib.pyopenssl
module.Both will be removed in v2.x. See this
GitHub issue <https://github.com/urllib3/urllib3/issues/2680>
_for justification and info on how to migrate.
v1.26.11
Compare Source
====================
HTTPResponse.read
wouldraise an
OverflowError
on Python 3.9 and earlier.v1.26.10
Compare Source
====================
ProxyError
recommending configuring the proxy as HTTPinstead of HTTPS could appear even when an HTTPS proxy wasn't configured.
v1.26.9
Compare Source
===================
urllib3[brotli]
extra to favor installing Brotli libraries that are stillreceiving updates like
brotli
andbrotlicffi
instead ofbrotlipy
.This change does not impact behavior of urllib3, only which dependencies are installed.
HTTPSConnection.connect()
raises an exception.server_hostname
being forwarded fromPoolManager
toHTTPConnectionPool
when requesting an HTTP URL. Should only be forwarded when requesting an HTTPS URL.
v1.26.8
Compare Source
===================
urllib3.exceptions.ProxyError
when urllib3 detects thata proxy is configured to use HTTPS but the proxy itself appears to only use HTTP.
Retry.MAX_BACKOFF
class property in favor ofRetry.DEFAULT_MAX_BACKOFF
to better match the rest of the default parameter names.
Retry.MAX_BACKOFF
is removed in v2.0.ssl.match_hostname
function fromurllib3.packages.ssl_match_hostname
to
urllib3.util.ssl_match_hostname
to ensure Python 3.10+ compatibility after being repackagedby downstream distributors.
v1.26.7
Compare Source
===================
of SNI. (Issue #2400)
matching. (Issue #2240)
v1.26.6
Compare Source
===================
urllib3.contrib.ntlmpool
module. urllib3 is not able to supportit properly due to
reasons listed in this issue <https://github.com/urllib3/urllib3/issues/2282>
_.If you are a user of this module please leave a comment.
HTTPConnection.request_chunked()
to not erroneously emit multipleTransfer-Encoding
headers in the case that one is already specified.Retry.DEFAULT_ALLOWED_METHODS
.v1.26.5
Compare Source
===================
six
library to 1.16.0.the authority component.
v1.26.4
Compare Source
===================
SSLContext
when connecting to HTTPS proxyduring HTTPS requests. The default
SSLContext
now setscheck_hostname=True
.v1.26.3
Compare Source
===================
Fixed bytes and string comparison issue with headers (Pull #2141)
Changed
ProxySchemeUnknown
error message to bemore actionable if the user supplies a proxy URL without
a scheme. (Pull #2107)
v1.26.2
Compare Source
===================
wrap_socket
andCERT_REQUIRED
wouldn'tbe imported properly on Python 2.7.8 and earlier (Pull #2052)
v1.26.1
Compare Source
====================
PoolManager
with many distinct originswould cause connection pools to be closed while requests are in progress (
#​2954 <https://github.com/urllib3/urllib3/pull/2954>
_)v1.26.0
Compare Source
===================
NOTE: urllib3 v2.0 will drop support for Python 2.
Read more in the v2.0 Roadmap <https://urllib3.readthedocs.io/en/latest/v2-roadmap.html>
_.Added support for HTTPS proxies contacting HTTPS servers (Pull #1923, Pull #1806)
Deprecated negotiating TLSv1 and TLSv1.1 by default. Users that
still wish to use TLS earlier than 1.2 without a deprecation warning
should opt-in explicitly by setting
ssl_version=ssl.PROTOCOL_TLSv1_1
(Pull #2002)Starting in urllib3 v2.0: Connections that receive a
DeprecationWarning
will failDeprecated
Retry
optionsRetry.DEFAULT_METHOD_WHITELIST
,Retry.DEFAULT_REDIRECT_HEADERS_BLACKLIST
and
Retry(method_whitelist=...)
in favor ofRetry.DEFAULT_ALLOWED_METHODS
,Retry.DEFAULT_REMOVE_HEADERS_ON_REDIRECT
, andRetry(allowed_methods=...)
(Pull #2000) Starting in urllib3 v2.0: Deprecated options will be removed
Added default
User-Agent
header to every request (Pull #1750)Added
urllib3.util.SKIP_HEADER
for skippingUser-Agent
,Accept-Encoding
,and
Host
headers from being automatically emitted with requests (Pull #2018)Collapse
transfer-encoding: chunked
request data and framing intothe same
socket.send()
call (Pull #1906)Send
http/1.1
ALPN identifier with every TLS handshake by default (Pull #1894)Properly terminate SecureTransport connections when CA verification fails (Pull #1977)
Don't emit an
SNIMissingWarning
when passingserver_hostname=None
to SecureTransport (Pull #1903)
Disabled requesting TLSv1.2 session tickets as they weren't being used by urllib3 (Pull #1970)
Suppress
BrokenPipeError
when writing request body after the serverhas closed the socket (Pull #1524)
Wrap
ssl.SSLError
that can be raised from reading a socket (e.g. "bad MAC")into an
urllib3.exceptions.SSLError
(Pull #1939)v1.25.11
Compare Source
====================
Fix retry backoff time parsed from
Retry-After
header when givenin the HTTP date format. The HTTP date was parsed as the local timezone
rather than accounting for the timezone in the HTTP date (typically
UTC) (Pull #1932, Pull #1935, Pull #1938, Pull #1949)
Fix issue where an error would be raised when the
SSLKEYLOGFILE
environment variable was set to the empty string. Now
SSLContext.keylog_file
is not set in this situation (Pull #2016)
v1.25.10
Compare Source
====================
Added support for
SSLKEYLOGFILE
environment variable forlogging TLS session keys with use with programs like
Wireshark for decrypting captured web traffic (Pull #1867)
Fixed loading of SecureTransport libraries on macOS Big Sur
due to the new dynamic linker cache (Pull #1905)
Collapse chunked request bodies data and framing into one
call to
send()
to reduce the number of TCP packets by 2-4x (Pull #1906)Don't insert
None
intoConnectionPool
if the poolwas empty when requesting a connection (Pull #1866)
Avoid
hasattr
call inBrotliDecoder.decompress()
(Pull #1858)v1.25.9
Compare Source
===================
Added
InvalidProxyConfigurationWarning
which is raised whenerroneously specifying an HTTPS proxy URL. urllib3 doesn't currently
support connecting to HTTPS proxies but will soon be able to
and we would like users to migrate properly without much breakage.
See
this GitHub issue <https://github.com/urllib3/urllib3/issues/1850>
_for more information on how to fix your proxy config. (Pull #1851)
Drain connection after
PoolManager
redirect (Pull #1817)Ensure
load_verify_locations
raisesSSLError
for all backends (Pull #1812)Rename
VerifiedHTTPSConnection
toHTTPSConnection
(Pull #1805)Allow the CA certificate data to be passed as a string (Pull #1804)
Raise
ValueError
if method contains control characters (Pull #1800)Add
__repr__
toTimeout
(Pull #1795)v1.25.8
Compare Source
===================
Drop support for EOL Python 3.4 (Pull #1774)
Optimize _encode_invalid_chars (Pull #1787)
v1.25.7
Compare Source
===================
Preserve
chunked
parameter on retries (Pull #1715, Pull #1734)Allow unset
SERVER_SOFTWARE
in App Engine (Pull #1704, Issue #1470)Fix issue where URL fragment was sent within the request target. (Pull #1732)
Fix issue where an empty query section in a URL would fail to parse. (Pull #1732)
Remove TLS 1.3 support in SecureTransport due to Apple removing support (Pull #1703)
v1.25.6
Compare Source
===================
~
) characters were incorrectlypercent-encoded in the path. (Pull #1692)
v1.25.5
Compare Source
===================
caused certificate verification to be enabled when using
cert_reqs=CERT_NONE
.(Issue #1682)
v1.25.4
Compare Source
===================
Propagate Retry-After header settings to subsequent retries. (Pull #1607)
Fix edge case where Retry-After header was still respected even when
explicitly opted out of. (Pull #1607)
Remove dependency on
rfc3986
for URL parsing.Fix issue where URLs containing invalid characters within
Url.auth
wouldraise an exception instead of percent-encoding those characters.
Add support for
HTTPResponse.auto_close = False
which makes HTTP responseswork well with BufferedReaders and other
io
module features. (Pull #1652)Percent-encode invalid characters in URL for
HTTPConnectionPool.request()
(Pull #1673)v1.25.3
Compare Source
===================
Change
HTTPSConnection
to load system CA certificateswhen
ca_certs
,ca_cert_dir
, andssl_context
areunspecified. (Pull #1608, Issue #1603)
Upgrade bundled rfc3986 to v1.3.2. (Pull #1609, Issue #1605)
v1.25.2
Compare Source
===================
Change
is_ipaddress
to not detect IPvFuture addresses. (Pull #1583)Change
parse_url
to percent-encode invalid characters within thepath, query, and target components. (Pull #1586)
v1.25.1
Compare Source
====================
Fix retry backoff time parsed from
Retry-After
header when givenin the HTTP date format. The HTTP date was parsed as the local timezone
rather than accounting for the timezone in the HTTP date (typically
UTC) (Pull #1932, Pull #1935, Pull #1938, Pull #1949)
Fix issue where an error would be raised when the
SSLKEYLOGFILE
environment variable was set to the empty string. Now
SSLContext.keylog_file
is not set in this situation (Pull #2016)
v1.25
Compare Source
====================
Fix retry backoff time parsed from
Retry-After
header when givenin the HTTP date format. The HTTP date was parsed as the local timezone
rather than accounting for the timezone in the HTTP date (typically
UTC) (Pull #1932, Pull #1935, Pull #1938, Pull #1949)
Fix issue where an error would be raised when the
SSLKEYLOGFILE
environment variable was set to the empty string. Now
SSLContext.keylog_file
is not set in this situation (Pull #2016)
v1.24.3
Compare Source
===================
v1.24.2
Compare Source
===================
Don't load system certificates by default when any other
ca_certs
,ca_certs_dir
orssl_context
parameters are specified.Remove Authorization header regardless of case when redirecting to cross-site. (Issue #1510)
Add support for IPv6 addresses in subjectAltName section of certificates. (Issue #1269)
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.