Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adopt nice #68

Merged
merged 1 commit into from
Jan 11, 2023
Merged

adopt nice #68

merged 1 commit into from
Jan 11, 2023

Conversation

mbostock
Copy link
Member

Fixes #67.

@mbostock mbostock requested a review from Fil January 11, 2023 05:23
@mbostock
Copy link
Member Author

mbostock commented Jan 11, 2023 •
edited
Loading

Before (note hole on bottom edge; 14 requested, 20 generated):
Screenshot 2023-01-10 at 9 29 22 PM

After (14 requested, 10 generated):
Screenshot 2023-01-10 at 9 28 14 PM

After (16 requested, 25 generated):
Screenshot 2023-01-10 at 9 33 22 PM

@mbostock mbostock merged commit f3902eb into main Jan 11, 2023
@mbostock mbostock deleted the mbostock/nice branch January 11, 2023 16:35
@mbostock mbostock mentioned this pull request Jan 16, 2023
Merged
@patrikpop10 patrikpop10 mentioned this pull request Sep 8, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fil Fil Fil approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sometimes the lowest threshold is missing
2 participants
@mbostock @Fil