Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unixDay interval #58

Merged
merged 2 commits into from
Dec 2, 2022
Merged

add unixDay interval #58

merged 2 commits into from
Dec 2, 2022

Conversation

mbostock
Copy link
Member

@mbostock mbostock commented Dec 1, 2022

Adds a d3.unixDay time interval as described in d3/d3-scale#245, and adopts it for d3.utcTicks in place of d3.utcDay such that ticks are always uniformly spaced.

Fixes observablehq/plot#1025.

@mbostock mbostock requested a review from Fil December 1, 2022 03:27
Copy link
Member

@Fil Fil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 happier histograms

@mbostock mbostock merged commit 850c1c2 into main Dec 2, 2022
@mbostock mbostock deleted the mbostock/unix-day branch December 2, 2022 23:24
@mbostock
Copy link
Member Author

mbostock commented Dec 3, 2022

Hmm, this fixes d3.utcTicks, but doesn’t help d3.timeTicks. Do we need an equivalent of d3.unixDay for local time, too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent Plot time bins
2 participants