Update d3-selection #205
Merged
Update d3-selection #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(rationale: don't let people install @2 in a build system that will not alert them that we have moved to ES6, only to cause trouble with a later release.)
notes: - needs https://github.com/d3/d3-selection/tree/two-multitouch-pointers d3/d3-selection@e84c95f for dbltap to work - needs d3-drag@2 also
(was a leftover from when I copied event code from d3-drag)
so that zoom.extent(function(event, d) {}) receives *null, datum*
…, …); and repair the calls that were mixed-up. *event-based functions:* - Gesture (hence event = this.args[0]) - filter - wheelDelta *selection-based functions:* - extent - transform - schedule - k,p (in scaleBy & scaleTo) - x,y (in translateBy) In addition, an event that triggers a transition (such as a zoom.dblclick) can be persisted throughout the transition as the zoomEvent.sourceEvent (fixes #202).
fixes #204 An unintended consequence is that wheel-zooming with the ctrlKey pressed goes 10x faster, but it's rather agreeable.
|
Cross-referencing comment: d3/d3-brush#71 (comment). |
x and y are scaled by t_k when calling t.translate(x,y)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo
allow event.on()?[removed]Please also consider: