Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggest: separate files for different key instead of one single json-file #6

Open
fintechdata opened this issue Nov 30, 2019 · 1 comment

Comments

@fintechdata
Copy link

Dear author,

Here is a suggest: to separate files for different key instead of one single json-file, that would improve performance in production env very well.... is pull request welcomed?

@d3x0r
Copy link
Owner

d3x0r commented Nov 30, 2019

Hello, I would consider it...
the cost of opening /tracking many files might be an issue... that, and the read side would slow, because basically every key it would have to see if it's already a file...
If the modification can be wrapped in an option the can be passed like 'file-pretty' do like 'file-auto-split:true/false'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants