From 69afbd1b33d8ad7f0672d137f12dd66e387a6729 Mon Sep 17 00:00:00 2001 From: Tomas Davidovic Date: Fri, 3 Nov 2023 11:02:03 +0100 Subject: [PATCH 1/2] Fixed a bug where solo aspect wasn't correctly parsed --- src/item/filter.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/item/filter.py b/src/item/filter.py index ab272736..4aa59733 100644 --- a/src/item/filter.py +++ b/src/item/filter.py @@ -111,7 +111,7 @@ def should_keep(item: Item): if item.aspect and filter_aspects is not None: for filter_data in filter_aspects: filter_aspect = [filter_data] if isinstance(filter_data, str) else filter_data - aspect_name, *rest = aspect if isinstance(filter_aspect, list) else [filter_aspect] + aspect_name, *rest = filter_aspect if isinstance(filter_aspect, list) else [filter_aspect] threshold = rest[0] if rest else None condition = rest[1] if len(rest) > 1 else "larger" From 3bca9e3b438f27bf4fe095efbaf612937cab3f03 Mon Sep 17 00:00:00 2001 From: Tomas Davidovic Date: Fri, 3 Nov 2023 11:28:48 +0100 Subject: [PATCH 2/2] Further cleanup of the non-array aspects --- src/item/filter.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/item/filter.py b/src/item/filter.py index 4aa59733..306c91b4 100644 --- a/src/item/filter.py +++ b/src/item/filter.py @@ -110,8 +110,7 @@ def should_keep(item: Item): if item.aspect and filter_aspects is not None: for filter_data in filter_aspects: - filter_aspect = [filter_data] if isinstance(filter_data, str) else filter_data - aspect_name, *rest = filter_aspect if isinstance(filter_aspect, list) else [filter_aspect] + aspect_name, *rest = filter_data if isinstance(filter_data, list) else [filter_data] threshold = rest[0] if rest else None condition = rest[1] if len(rest) > 1 else "larger"