Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --zstd-workers option #116

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Conversation

akirakubo
Copy link
Contributor

This PR attempts to add --zstd-workers option for multithreaded zstd compression.
zstd compression could take longer than training when using large dictionaries such as NEologd.
This option reduces compression time.

  1. Added zstdmt feature to enable multithread method
  2. Added zstd_workers argument for the number of workers for zstd. Default is zero that disables multithread.
  3. Added codes to call multithread method with zstd_workers

@vbkaisetsu vbkaisetsu self-requested a review November 5, 2023 15:33
@vbkaisetsu
Copy link
Member

@akirakubo Thank you for the great improvement.

There is a compile error in Nightly Rust. rust-lang/rust#117602
I will merge this PR after it is fixed.

@vbkaisetsu vbkaisetsu enabled auto-merge (squash) November 8, 2023 06:43
@vbkaisetsu vbkaisetsu enabled auto-merge (squash) November 9, 2023 05:18
@vbkaisetsu vbkaisetsu merged commit f01f5e9 into daac-tools:main Nov 9, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants