Fix GetWrappedType implementation(s) to not return null #560
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change:
I tried to resolve
IContainer
through third-partySplat.DryIoc
dependency resolver in my app (bad practice but WinForms is a bad practice by itself, so eh). It errored with aNullReferenceException
here (none of the params were generic):DryIoc/src/DryIoc/Container.cs
Lines 5072 to 5077 in e6a4e33
Upon further inspection I found out that the methods shouldn't ever return
null
, according to documentation:DryIoc/src/DryIoc/Container.cs
Line 14054 in e6a4e33
And here:
DryIoc/src/DryIoc/Container.cs
Line 14059 in e6a4e33
Yet one of the branches was seemingly erratically returning null, so I fixed that.