Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove esbuild #144

Merged
merged 2 commits into from
Oct 25, 2023
Merged

refactor: remove esbuild #144

merged 2 commits into from
Oct 25, 2023

Conversation

himself65
Copy link
Contributor

@himself65 himself65 commented Oct 25, 2023 •
edited
Loading

@vercel
Copy link

vercel bot commented Oct 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 2:45am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 25, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3f33495:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
React Configuration
React TypeScript Configuration

dai-shi
dai-shi reviewed Oct 25, 2023
View reviewed changes
Copy link
Owner

@dai-shi dai-shi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. We thought about using swc but tsc would work too. Would you be interested in doing it with swc, like packages/waku?

packages/create-waku/tsconfig.json Outdated Show resolved Hide resolved
@himself65 @dai-shi
Update packages/create-waku/tsconfig.json
3f33495 
Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com>
@himself65
Copy link
Contributor Author

Would you be interested in doing it with swc, like packages/waku?

I tried, that is impossible if the project both output cjs and esm, since tsconfig will check require in cjs, import.meta.url in esm. they cannot both together

@dai-shi
Copy link
Owner

dai-shi commented Oct 25, 2023

Interesting. I wasn't aware of it.

Did you try the cli locally to see if works as expected? Can I merge and just release it?

@himself65
Copy link
Contributor Author

I tried it, works

dai-shi
dai-shi approved these changes Oct 25, 2023
View reviewed changes
Copy link
Owner

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much.

@dai-shi dai-shi merged commit 188ea3e into dai-shi:main Oct 25, 2023
5 checks passed
@himself65 himself65 deleted the create-waku branch October 25, 2023 02:59
@dai-shi dai-shi mentioned this pull request Nov 17, 2023
Closed
@himself65 himself65 mentioned this pull request Jan 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dai-shi dai-shi dai-shi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@himself65 @dai-shi