test: Extended ThrowIfNullOrEmpty tests

[samtrion]

Summary by CodeRabbit

• Tests
  • Added two unit tests covering empty-collection handling for the null-or-empty guard (including an async variant).
  • Introduced an async test using directive to support async assertions.
  • Expanded test data providers to better validate enumerable edge cases and expected failures.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Added two new unit tests to verify ThrowIfNullOrEmpty behavior for IEnumerable inputs and introduced a using directive for async Task support. No production code changes.

Changes

Cohort / File(s)	Summary
Unit tests (single file) tests/NetEvolve.Arguments.Tests.Unit/ArgumentTests_ThrowIfNullOrEmpty.cs	Added two test methods: ThrowIfNullOrEmpty_WhenIEnumerableEmpty_ThrowsArgumentException(IEnumerable<string>? argument) (uses ThrowIfNullOrEmptyEnumerableData) and ThrowIfNullOrEmpty_WhenIEnumerableEmpty_Expected(IEnumerable<string>? argument) (uses ThrowIfNullOrEmptyEnumerableWithData and runs async assertions). Also added using System.Threading.Tasks;.

Sequence Diagram(s)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Single test file changed; low complexity.
• Pay attention to:
  • Which exception type is asserted (ArgumentException vs ArgumentNullException).
  • Proper use of the provided data sources (ThrowIfNullOrEmptyEnumerableData vs ThrowIfNullOrEmptyEnumerableWithData).
  • Async test signature and the newly added using System.Threading.Tasks;.

Poem

🐇 I nibble on tests, a carrot of code,

Empty lists caught on the bright rabbit road.
New assertions hop in, tidy and spry,
Async hops added — a cheerful small cry.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and concisely describes the main change: adding extended tests for the ThrowIfNullOrEmpty method, which matches the changeset of adding new test cases.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch test/added-missing-test

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 1ff3705 and 7bc9d5e.

📒 Files selected for processing (1)

• tests/NetEvolve.Arguments.Tests.Unit/ArgumentTests_ThrowIfNullOrEmpty.cs (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• tests/NetEvolve.Arguments.Tests.Unit/ArgumentTests_ThrowIfNullOrEmpty.cs

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

tests/NetEvolve.Arguments.Tests.Unit/ArgumentTests_ThrowIfNullOrEmpty.cs (1)

61-70: Consider adding test coverage for non-empty IEnumerable (success case).

The test suite now covers null IEnumerable (line 49) and empty IEnumerable (line 61), but lacks coverage for non-empty IEnumerable that should succeed without throwing. The string tests include this success case (lines 36-46). According to the summary, ThrowIfNullOrEmptyEnumerableWithData was removed, which appears to have provided this coverage.

Consider adding a parameterized test for the success case to maintain symmetry with the string tests:

[Test]
[MethodDataSource(nameof(ThrowIfNullOrEmptyEnumerableWithData))]
public async Task ThrowIfNullOrEmpty_WhenIEnumerableNotEmpty_ReturnsArgument(IEnumerable<string> argument)
{
    // Act
    var result = Argument.ThrowIfNullOrEmpty(argument);

    // Assert
    _ = await Assert.That(result).IsNotNull();
}

public static IEnumerable<IEnumerable<string>> ThrowIfNullOrEmptyEnumerableWithData =>
    [new[] { "argument" }, new List<string> { "argument" }, new HashSet<string> { "argument" }];

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 7755da5 and 1ff3705.

📒 Files selected for processing (1)

• tests/NetEvolve.Arguments.Tests.Unit/ArgumentTests_ThrowIfNullOrEmpty.cs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Build & Tests / Run Tests / Testing .NET solution

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.29%. Comparing base (7755da5) to head (7bc9d5e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #393       +/-   ##
===========================================
+ Coverage   77.77%   96.29%   +18.51%     
===========================================
  Files          11       11               
  Lines          27       27               
  Branches        2        2               
===========================================
+ Hits           21       26        +5     
+ Misses          5        1        -4     
+ Partials        1        0        -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.