-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: an Electron Axe runner for Ace (side-by-side with the Puppeteer one) #236
Conversation
…ists in yarn upgrade (semantic versioning minor updates)
…-rf node_modules && rm -rf packages/*/node_modules && rm yarn.lock && yarn install && yarn build && yarn test
To compare performance:
...right now the Electron runner is slower that the Puppeteer one due to launching multiple browser windows in sequence (no concurrency). |
The Electron-based Axe runner now has the same performance as the Puppeteer one. To check, use this shell script (which is committed at the root of this repository):
|
…tron and Puppeteer implementations
…ndling packages with different versions
… with arbitrary garbage collection (this is needed for Ace App/GUI metadata editor)
…with mkdirp, well ... "Drop support for outdated Node.js versions. (Technically still works on Node.js v8, but only 10 and above are officially supported.)" see https://github.com/isaacs/node-mkdirp/blob/master/CHANGELOG.md )
…e + EPUB2 metadata name/content pairs were not parsed + added certifierReport in addition to conformsTo (special metadata/link case) + added missing description fields to HTML report (otherwise violations are reported with insufficient information to remediate) + added missing a11y:certifierCredential reporting
…, so let's optimize the path queries)
…fied / cross-checked with the DAISY Knowledge Base 's recommended values)
…cation notice) in both unit tests CLI and regular
…top and sub-level node_modules)
PR now superseded with #314 |
Note that this has its own CLI, due to the way an Electron app is bootstrapped. However, there is no code redundancy due to the introduction of the "shared" CLI package.