Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo LayoutEngineCustomAction breaking name change #917

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

dalyIsaac
Copy link
Owner

@dalyIsaac dalyIsaac commented Jun 27, 2024

In #909 I went a bit overzealous with a simplification which I wouldn't think would hit anyone. LayoutEngineAction has been renamed back to LayoutEngineCustomAction.

@dalyIsaac dalyIsaac added refactor The code can be simplified/moved/cleaned up core Whim labels Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.71%. Comparing base (1ac3bab) to head (43abbd6).

Files Patch % Lines
src/Whim.TestUtils/ImmutableTestLayoutEngine.cs 0.00% 1 Missing ⚠️
src/Whim.TestUtils/TestLayoutEngine.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #917      +/-   ##
==========================================
+ Coverage   80.69%   80.71%   +0.01%     
==========================================
  Files         271      271              
  Lines       11227    11234       +7     
  Branches     1258     1258              
==========================================
+ Hits         9060     9067       +7     
  Misses       1995     1995              
  Partials      172      172              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dalyIsaac dalyIsaac added bug Something isn't working and removed refactor The code can be simplified/moved/cleaned up labels Jun 27, 2024
@dalyIsaac dalyIsaac marked this pull request as ready for review June 27, 2024 11:25
@dalyIsaac dalyIsaac merged commit 2f6dc23 into main Jun 27, 2024
12 checks passed
@dalyIsaac dalyIsaac deleted the layout-engine-action branch June 27, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core Whim
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant