Fix GitJSONDSL and diffForFile for BitBucket Server
#764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@orta could you review, please? |
langovoi
commented
Nov 14, 2018
|
|
||
| values = values.concat(data.values) | ||
| nextPageStart = data.nextPageStart | ||
| } while (nextPageStart !== null) |
There was a problem hiding this comment.
Collect all pages with changes
langovoi
commented
Nov 14, 2018
| @@ -3,7 +3,7 @@ import { dangerSignaturePostfix } from "../../../runner/templates/bitbucketServe | |||
|
|
|||
| describe("API testing - BitBucket Server", () => { | |||
| let api: BitBucketServerAPI | |||
| let jsonResult: any | |||
| let jsonResult: () => any | |||
There was a problem hiding this comment.
Allowing to set jsonResult as function. For example for use jest.fn
langovoi
commented
Nov 14, 2018
| nextPageStart: 1, | ||
| values: ["1"], | ||
| }) | ||
| .mockReturnValueOnce({ |
There was a problem hiding this comment.
Simulate iteration by pages
|
OK, cool, yeah this looks good 👍 |
|
Great! Could you make new release, please? |
|
Yep, this came out in 6.1.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bitbucket Server API for
diffsometimes returntruncated: truein root of response.This means that Bitbucket Server don't provide full diff of all files.
In my practical with Danger, this breaks
modified_files,created_filesanddeleted_files.Bitbucket Server has another API, which returns list of changes in PR, without diff.
I replaced
diffAPI withchangesAPI for generationGitJSONDSL.Also I reworked
diffForFileto fix potential bug with Bitbucket Server, whendiffAPI may return truncated results.