update signals for shell 3.18 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since gnome-shell version 3.18, the 'maximize' and 'unmaximize' signals were replaced by a single 'size-change' signal. This is a port of commit 4eadd6eba8c2104a3b203ff86a115a1723e9b7d7 of the dash-to-dock extension.
|
Thanks for reminding me, I've seen this on other extensions. I'll create a branch for 3.16 and merge this in a minute. |
danielkza
added a commit
that referenced
this pull request
Oct 11, 2015
update signals for shell 3.18
|
Thanks for the quick processing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since gnome-shell version 3.18, there are no 'maximize' and 'unmaximize' signals any more, but only a single 'size-change' signal. This makes window-buttons fail to load with an error message about the lack of these signals as long as it is set to only modify maximized windows.
The dash-to-dock extension also encountered this change in commit 4eadd6eba8c2104a3b203ff86a115a1723e9b7d7. I took their solution and ported it here, which works fine for me so far.