-
Notifications
You must be signed in to change notification settings - Fork 0
Fix uncoalesced global accesses #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stack-info: PR: #11, branch: danielvegamyhre/stack/5
danielvegamyhre
added a commit
that referenced
this pull request
Jul 6, 2025
stack-info: PR: #11, branch: danielvegamyhre/stack/5
69e763c to
b8dbadc
Compare
This was referenced Jul 6, 2025
Merged
danielvegamyhre
added a commit
that referenced
this pull request
Jul 6, 2025
stack-info: PR: #11, branch: danielvegamyhre/stack/5
b8dbadc to
fef90a8
Compare
fef90a8 to
3631dea
Compare
2db90aa to
b4c0a32
Compare
danielvegamyhre
added a commit
that referenced
this pull request
Jul 6, 2025
stack-info: PR: #11, branch: danielvegamyhre/stack/5
3631dea to
2039e19
Compare
b4c0a32 to
6b830dc
Compare
danielvegamyhre
added a commit
that referenced
this pull request
Jul 6, 2025
stack-info: PR: #11, branch: danielvegamyhre/stack/5
2039e19 to
28a31b6
Compare
6b830dc to
a5f03d8
Compare
danielvegamyhre
added a commit
that referenced
this pull request
Jul 6, 2025
stack-info: PR: #11, branch: danielvegamyhre/stack/5
2c4677c to
c40ace9
Compare
This was referenced Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Fix uncoalesced global accesses
Need scales_colwise to be the shape (num_blocks, columns, 1) so the 'column' dim stride is 1, so we can avoid uncoalesced writes to global memory.
This is because each of the 32 threads in a warp will be computing a scale for a different column of 32 input data values, then each writing that scale to global memory, one per column - so the stride along this
coldim should be 1 so writes can be coalesced into a single transaction.NCU before change
NCU after change