Throw internal error when tokens are not in order (#4623)

pfultz2 · web-flow · commit 6eccb2e36c1d · 2022-12-09T07:17:16.000+01:00
* Throw internal error when tokens are not in order

* Add semicolon
diff --git a/lib/valueflow.cpp b/lib/valueflow.cpp
@@ -5331,6 +5331,8 @@ static void valueFlowForwardConst(Token* start,
                                   const Settings* const settings,
                                   int /*unused*/ = 0)
 {
+    if (!precedes(start, end))
+        throw InternalError(var->nameToken(), "valueFlowForwardConst: start token does not precede the end token.");
     for (Token* tok = start; tok != end; tok = tok->next()) {
         if (tok->varId() == var->declarationId()) {
             for (const ValueFlow::Value& value : values)

Original file line number	Diff line number	Diff line change
`@@ -5331,6 +5331,8 @@ static void valueFlowForwardConst(Token* start,`
`5331`	`5331`	`const Settings* const settings,`
`5332`	`5332`	`int /unused/ = 0)`
`5333`	`5333`	`{`
	`5334`	`+ if (!precedes(start, end))`
	`5335`	`+ throw InternalError(var->nameToken(), "valueFlowForwardConst: start token does not precede the end token.");`
`5334`	`5336`	`for (Token* tok = start; tok != end; tok = tok->next()) {`
`5335`	`5337`	`if (tok->varId() == var->declarationId()) {`
`5336`	`5338`	`for (const ValueFlow::Value& value : values)`