Add wallet selector if signer not found #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
If you login in another device with grill key / share session, the app won't know which wallet has your connected wallet address
Right now, it just check the first wallet, and if its not found, it just errors out.
Fix
If signer is not found, it will ask user to select which address to connect so the app will know which wallet to use, and user will have clearer info on why the error happens if the account is not there
Image 1: it will select the currently saved wallet in local storage, if there is any. If the selected wallet doesn't contain the connected address, it will show the notice and disabled button
Image 2: when user clicks the other, wallet, which contains the address, notice will disappear and user can close or click the button to continue signing the tx