Update is_available condition #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
reviewed
Feb 29, 2024
| @@ -198,7 +207,9 @@ pub trait AvailabilityView<E: EthSpec> { | |||
| /// of expected blobs. | |||
| fn is_available(&self) -> bool { | |||
| if let Some(num_expected_blobs) = self.num_expected_blobs() { | |||
| // Note: the first equality covers the case of no columns to sample post EIP-7594 | |||
jimmygchen
reviewed
Feb 29, 2024
| num_expected_blobs == self.num_received_blobs() | ||
| || self.num_received_columns() >= self.samples_per_slot() |
There was a problem hiding this comment.
Note that the get_cached_data_columns currently stores the gossip verified data columns, so it's really the custody_columns rather than the sample columns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update AvailabilityView is_available condition to consider the case where one has sampled sufficient columns