Skip to content

Commit dbc8db3

Browse files
committed
switch to golang-jwt
Signed-off-by: Long Dai <long0dai@foxmail.com>
1 parent ff65172 commit dbc8db3

File tree

4 files changed

+13
-16
lines changed

4 files changed

+13
-16
lines changed

bindings/apns/authorization_builder.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import (
1010
"time"
1111

1212
"github.com/dapr/kit/logger"
13-
jwt "github.com/dgrijalva/jwt-go/v4"
13+
"github.com/golang-jwt/jwt"
1414
)
1515

1616
// The "issued at" timestamp in the JWT must be within one hour from the
@@ -57,7 +57,7 @@ func (a *authorizationBuilder) generateAuthorizationHeader() (string, error) {
5757

5858
now := time.Now()
5959
claims := jwt.StandardClaims{
60-
IssuedAt: jwt.Now(),
60+
IssuedAt: time.Now().Unix(),
6161
Issuer: a.teamID,
6262
}
6363
token := jwt.NewWithClaims(jwt.SigningMethodES256, claims)

bindings/azure/signalr/signalr.go

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import (
1616

1717
"github.com/dapr/components-contrib/bindings"
1818
"github.com/dapr/kit/logger"
19-
"github.com/dgrijalva/jwt-go/v4"
19+
"github.com/golang-jwt/jwt"
2020
"github.com/pkg/errors"
2121
)
2222

@@ -173,7 +173,7 @@ func (s *SignalR) Invoke(req *bindings.InvokeRequest) (*bindings.InvokeResponse,
173173
}
174174

175175
func (s *SignalR) ensureValidToken(url string) (string, error) {
176-
now := jwt.Now()
176+
now := time.Now()
177177

178178
if existing, ok := s.tokens[url]; ok {
179179
if existing.token != "" && now.Before(existing.expiration) {
@@ -182,16 +182,14 @@ func (s *SignalR) ensureValidToken(url string) (string, error) {
182182
}
183183

184184
expiration := now.Add(1 * time.Hour)
185-
audience, err := jwt.ParseClaimStrings(url)
186-
if err != nil {
187-
return "", err
188-
}
189185

190186
claims := &jwt.StandardClaims{
191-
ExpiresAt: &jwt.Time{
192-
Time: expiration,
193-
},
194-
Audience: audience,
187+
ExpiresAt: expiration.Unix(),
188+
Audience: url,
189+
}
190+
191+
if err := claims.Valid(); err != nil {
192+
return "", err
195193
}
196194

197195
token := jwt.NewWithClaims(jwt.SigningMethodHS256, claims)

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ require (
4646
github.com/denisenkom/go-mssqldb v0.0.0-20191128021309-1d7a30a10f73
4747
github.com/dghubble/go-twitter v0.0.0-20190719072343-39e5462e111f
4848
github.com/dghubble/oauth1 v0.6.0
49-
github.com/dgrijalva/jwt-go/v4 v4.0.0-preview1
5049
github.com/didip/tollbooth v4.0.2+incompatible
5150
github.com/dnaeon/go-vcr v1.1.0 // indirect
5251
github.com/eapache/go-resiliency v1.2.0 // indirect
@@ -62,6 +61,7 @@ require (
6261
github.com/go-redis/redis/v8 v8.8.0
6362
github.com/go-sql-driver/mysql v1.5.0
6463
github.com/gocql/gocql v0.0.0-20210515062232-b7ef815b4556
64+
github.com/golang-jwt/jwt v3.2.1+incompatible
6565
github.com/golang/mock v1.5.0
6666
github.com/golang/protobuf v1.4.3
6767
github.com/golang/snappy v0.0.3 // indirect

go.sum

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -282,10 +282,7 @@ github.com/dghubble/oauth1 v0.6.0 h1:m1yC01Ohc/eF38jwZ8JUjL1a+XHHXtGQgK+MxQbmSx0
282282
github.com/dghubble/oauth1 v0.6.0/go.mod h1:8pFdfPkv/jr8mkChVbNVuJ0suiHe278BtWI4Tk1ujxk=
283283
github.com/dghubble/sling v1.3.0 h1:pZHjCJq4zJvc6qVQ5wN1jo5oNZlNE0+8T/h0XeXBUKU=
284284
github.com/dghubble/sling v1.3.0/go.mod h1:XXShWaBWKzNLhu2OxikSNFrlsvowtz4kyRuXUG7oQKY=
285-
github.com/dgrijalva/jwt-go v3.2.0+incompatible h1:7qlOGliEKZXTDg6OTjfoBKDXWrumCAMpl/TFQ4/5kLM=
286285
github.com/dgrijalva/jwt-go v3.2.0+incompatible/go.mod h1:E3ru+11k8xSBh+hMPgOLZmtrrCbhqsmaPHjLKYnJCaQ=
287-
github.com/dgrijalva/jwt-go/v4 v4.0.0-preview1 h1:CaO/zOnF8VvUfEbhRatPcwKVWamvbYd8tQGRWacE9kU=
288-
github.com/dgrijalva/jwt-go/v4 v4.0.0-preview1/go.mod h1:+hnT3ywWDTAFrW5aE+u2Sa/wT555ZqwoCS+pk3p6ry4=
289286
github.com/dgryski/go-rendezvous v0.0.0-20200823014737-9f7001d12a5f h1:lO4WD4F/rVNCu3HqELle0jiPLLBs70cWOduZpkS1E78=
290287
github.com/dgryski/go-rendezvous v0.0.0-20200823014737-9f7001d12a5f/go.mod h1:cuUVRXasLTGF7a8hSLbxyZXjz+1KgoB3wDUb6vlszIc=
291288
github.com/dgryski/go-sip13 v0.0.0-20181026042036-e10d5fee7954/go.mod h1:vAd38F8PWV+bWy6jNmig1y/TA+kYO4g3RSRF0IAv0no=
@@ -432,6 +429,8 @@ github.com/gogo/protobuf v1.3.1/go.mod h1:SlYgWuQ5SjCEi6WLHjHCa1yvBfUnHcTbrrZtXP
432429
github.com/gogo/protobuf v1.3.2 h1:Ov1cvc58UF3b5XjBnZv7+opcTcQFZebYjWzi34vdm4Q=
433430
github.com/gogo/protobuf v1.3.2/go.mod h1:P1XiOD3dCwIKUDQYPy72D8LYyHL2YPYrpS2s69NZV8Q=
434431
github.com/goji/httpauth v0.0.0-20160601135302-2da839ab0f4d/go.mod h1:nnjvkQ9ptGaCkuDUx6wNykzzlUixGxvkme+H/lnzb+A=
432+
github.com/golang-jwt/jwt v3.2.1+incompatible h1:73Z+4BJcrTC+KczS6WvTPvRGOp1WmfEP4Q1lOd9Z/+c=
433+
github.com/golang-jwt/jwt v3.2.1+incompatible/go.mod h1:8pz2t5EyA70fFQQSrl6XZXzqecmYZeUEB8OUGHkxJ+I=
435434
github.com/golang-sql/civil v0.0.0-20190719163853-cb61b32ac6fe h1:lXe2qZdvpiX5WZkZR4hgp4KJVfY3nMkvmwbVkpv1rVY=
436435
github.com/golang-sql/civil v0.0.0-20190719163853-cb61b32ac6fe/go.mod h1:8vg3r2VgvsThLBIFL93Qb5yWzgyZWhEmBwUJWevAkK0=
437436
github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b/go.mod h1:SBH7ygxi8pfUlaOkMMuAQtPIUF8ecWP5IEl/CR7VP2Q=

0 commit comments

Comments
 (0)