Skip to content

Conversation

@CodeMonkeyLeet
Copy link
Contributor

@CodeMonkeyLeet CodeMonkeyLeet commented Jul 13, 2021

Description

  • Update azure-event-hubs-go dependency to currently supported v3 with IoT Hub SystemProperties.
  • Write Event.SystemProperties to ReadResponse.Metadata for EventHubs input binding.
  • Write Event.SystemProperties to NewMessage.Metadata for EventHubs pubsub.

Issue reference

Fixes: #227

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@CodeMonkeyLeet CodeMonkeyLeet requested review from a team as code owners July 13, 2021 20:07
- Update azure-event-hubs-go dependency to currently supported v3 with
  IoT Hub SystemProperties.
- Write Event.SystemProperties to ReadResponse.Metadata for EventHubs
  input binding.
- Write Event.SystemProperties to NewMessage.Metadata for EventHubs
  pubsub.
@CodeMonkeyLeet CodeMonkeyLeet force-pushed the support_iothub_metadata branch from 25a4edb to 700a722 Compare July 13, 2021 21:09
@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #1009 (700a722) into master (01147e5) will increase coverage by 3.59%.
The diff coverage is 37.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1009      +/-   ##
==========================================
+ Coverage   30.59%   34.18%   +3.59%     
==========================================
  Files          85      132      +47     
  Lines        7148    10592    +3444     
==========================================
+ Hits         2187     3621    +1434     
- Misses       4724     6594    +1870     
- Partials      237      377     +140     
Impacted Files Coverage Δ
bindings/alicloud/oss/oss.go 11.11% <ø> (ø)
bindings/alicloud/rocketmq/rocketmq.go 0.00% <0.00%> (ø)
bindings/apns/apns.go 88.00% <ø> (ø)
bindings/aws/dynamodb/dynamodb.go 10.52% <ø> (ø)
bindings/aws/kinesis/kinesis.go 2.61% <ø> (ø)
bindings/aws/s3/s3.go 10.81% <ø> (ø)
bindings/aws/sns/sns.go 10.52% <ø> (ø)
bindings/aws/sqs/sqs.go 6.55% <0.00%> (ø)
bindings/azure/blobstorage/blobstorage.go 7.54% <0.00%> (-0.30%) ⬇️
bindings/azure/cosmosdb/cosmosdb.go 25.71% <ø> (ø)
... and 173 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb9a510...700a722. Read the comment docs.

@CodeMonkeyLeet
Copy link
Contributor Author

@artursouza @pkedy This needs a review if it is targeted for v1.3

@artursouza artursouza merged commit 3877f5c into dapr:master Jul 13, 2021
Taction added a commit to Taction/components-contrib that referenced this pull request Jul 15, 2021
* master: (23 commits)
  Adds support for TTL in Redis State Store (dapr#990)
  Adds support for TTL in Memcached State Store (PR Fixup) (dapr#1011)
  Adds support for TTL in Cassandra State Store (dapr#996)
  Return blob metadata and add list operation (dapr#999)
  Added new output binding for Cosmos Graph DB - Gremlin (dapr#885)
  Adds support for TTL in CosmosDB State Store (dapr#991)
  Delete unused code and update test (dapr#924)
  Return SystemProperties on events from EventHubs bindings and pubsub (dapr#1009)
  Implement E2E tests for zeebe (dapr#973)
  rebase (dapr#982)
  Update CODEOWNERS (dapr#987)
  ci: add test skip case (dapr#922)
  fix: Mysql should support more data types. dapr#923 (dapr#926)
  fix: Dapr runtime panic when handle Pub/Sub (dapr#3281) (dapr#967)
  switch to golang-jwt (dapr#993)
  unmarshal getBlobRetryCount as int (dapr#919)
  secretstores: support more format of azure key vault (dapr#944)
  Optimize vault secret component error output (dapr#909)
  Convert AZURE_KEYVAULT in conformance.yml a GitHub secret (dapr#1002)
  Use AzureKeyVaultName param for Azure Keyvault conformance test (dapr#975)
  ...

# Conflicts:
#	secretstores/hashicorp/vault/vault.go
@CodeMonkeyLeet CodeMonkeyLeet deleted the support_iothub_metadata branch August 18, 2021 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Event-Hub input binding should propagate event meta-data

2 participants