ci: standard linter config #1102
Conversation
CodeMonkeyLeet
left a comment
CodeMonkeyLeet
left a comment
There was a problem hiding this comment.
LGTM, basically applying the dapr/dapr/.golangci.yml and then fixing all the static analysis checks, correct?
We probably want to try and coordinate the merge for this since it touches so many files and any new PR merge has the potential to require new lint fixes. @artursouza Do we have a window after codefreeze for v1.4 to push this set of PRs?
daixiang0
force-pushed
the
lint-config
branch
from
889e5b9 to
2a52b1a
Compare
artursouza
left a comment
artursouza
left a comment
There was a problem hiding this comment.
When the comment is a command, JSON or XML, then we want the content to be as-is and not have a period. Is there a way to disable lint for those?
daixiang0
force-pushed
the
lint-config
branch
2 times, most recently
from
fe32431 to
d2ce952
Compare
Add |
daixiang0
force-pushed
the
lint-config
branch
2 times, most recently
from
e7d5a9c to
d02ec45
Compare
Signed-off-by: Long <long.dai@intel.com>
Codecov Report
@@ Coverage Diff @@
## master #1102 +/- ##
==========================================
+ Coverage 33.70% 33.81% +0.10%
==========================================
Files 138 138
Lines 11635 11674 +39
==========================================
+ Hits 3922 3947 +25
- Misses 7308 7317 +9
- Partials 405 410 +5
Continue to review full report at Codecov.
|
Signed-off-by: Long <long.dai@intel.com>
* master: fix 'durable' setting in RabbitMQ (dapr#1183) Support setting up Azure IoT Hub for integration testing with EventHubs components (dapr#1174) gcp bucket update (dapr#1128) ok-to-test changes for components-contrib (dapr#1091) version stored procedure due to previous changes made (dapr#1176) Fix existing integration tests (dapr#1173) Add state alicloud.tablestore (dapr#1116) Add dapr user agent for Azure Components (dapr#1152) Support using setup-azure-conf-test.sh with existing Service Principal (dapr#1158) Add Event Hubs conformance tests to conformance.yml workflow (dapr#1164) restructure code and add comments per code review cover all concurrency + etag cases Fix EOF linebreaks Adds first-write conformance test update metadata key fix linter warnings TableStorage conformance tests pass TableStore config tablestorage conformance WIP ci: standard linter config (dapr#1102) # Conflicts: # secretstores/hashicorp/vault/vault.go
* ci: standard linter config Signed-off-by: Long <long.dai@intel.com> * Update utils.go * fix pulsar issue Signed-off-by: Long <long.dai@intel.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
3 participants
Signed-off-by: Long long0dai@foxmail.com
Description
Ref dapr/dapr#3537
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: