-
Notifications
You must be signed in to change notification settings - Fork 543
Fix existing integration tests #1173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@artursouza, refactor of #1142 to unblock @halspang |
3 tasks
6a296be to
08679ba
Compare
Codecov Report
@@ Coverage Diff @@
## master #1173 +/- ##
==========================================
+ Coverage 33.77% 34.45% +0.68%
==========================================
Files 138 140 +2
Lines 11686 11890 +204
==========================================
+ Hits 3947 4097 +150
- Misses 7329 7375 +46
- Partials 410 418 +8
Continue to review full report at Codecov.
|
halspang
approved these changes
Sep 28, 2021
artursouza
approved these changes
Sep 29, 2021
Taction
added a commit
to Taction/components-contrib
that referenced
this pull request
Oct 6, 2021
* master: fix 'durable' setting in RabbitMQ (dapr#1183) Support setting up Azure IoT Hub for integration testing with EventHubs components (dapr#1174) gcp bucket update (dapr#1128) ok-to-test changes for components-contrib (dapr#1091) version stored procedure due to previous changes made (dapr#1176) Fix existing integration tests (dapr#1173) Add state alicloud.tablestore (dapr#1116) Add dapr user agent for Azure Components (dapr#1152) Support using setup-azure-conf-test.sh with existing Service Principal (dapr#1158) Add Event Hubs conformance tests to conformance.yml workflow (dapr#1164) restructure code and add comments per code review cover all concurrency + etag cases Fix EOF linebreaks Adds first-write conformance test update metadata key fix linter warnings TableStorage conformance tests pass TableStore config tablestorage conformance WIP ci: standard linter config (dapr#1102) # Conflicts: # secretstores/hashicorp/vault/vault.go
amimimor
pushed a commit
to amimimor/components-contrib
that referenced
this pull request
Dec 9, 2021
* Fix servicebusqueues_integration_test.go compile errors * Fix postgresql_integration_test.go deleteItemThatDoesNotExist expectations * Fix mysql_integration_test.go deleteItemThatDoesNotExist expectations * Fix mysql_integration_test.go for bindings * Increase TTL in ServiceBusQueues tests for stability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix existing failures in components integration tests
Issue reference
N/A
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: