Skip to content

Conversation

@berndverst
Copy link
Member

@berndverst berndverst commented Sep 30, 2021

Description

SQLServer upsert procedure is now versioned (new name) to ensure everyone uses the latest correct version of the stored procedure when updating Dapr.

Issue reference

As per #1175

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Manually ran conformance tests and integration tests against Azure SQL Server.

@berndverst berndverst requested review from a team as code owners September 30, 2021 01:01
@berndverst
Copy link
Member Author

@CodeMonkeyLeet please take a look :)

@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #1176 (8ccb134) into master (905cbc0) will increase coverage by 0.68%.
The diff coverage is 70.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1176      +/-   ##
==========================================
+ Coverage   33.77%   34.45%   +0.68%     
==========================================
  Files         138      140       +2     
  Lines       11686    11890     +204     
==========================================
+ Hits         3947     4097     +150     
- Misses       7329     7375      +46     
- Partials      410      418       +8     
Impacted Files Coverage Δ
bindings/azure/blobstorage/blobstorage.go 14.61% <0.00%> (-0.21%) ⬇️
bindings/azure/eventgrid/eventgrid.go 3.84% <0.00%> (-0.10%) ⬇️
bindings/azure/eventhubs/eventhubs.go 16.66% <0.00%> (-0.66%) ⬇️
...indings/azure/servicebusqueues/servicebusqueues.go 14.66% <0.00%> (-0.41%) ⬇️
bindings/azure/storagequeues/storagequeues.go 37.61% <0.00%> (-1.81%) ⬇️
pubsub/azure/eventhubs/eventhubs.go 23.40% <0.00%> (-0.51%) ⬇️
pubsub/azure/servicebus/servicebus.go 30.19% <0.00%> (-0.30%) ⬇️
state/azure/tablestorage/tablestorage.go 11.86% <0.00%> (-0.21%) ⬇️
state/mongodb/mongodb.go 16.29% <0.00%> (-0.48%) ⬇️
state/sqlserver/migration.go 0.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a075cb...8ccb134. Read the comment docs.

@artursouza artursouza merged commit 317db02 into dapr:master Sep 30, 2021
Taction added a commit to Taction/components-contrib that referenced this pull request Oct 6, 2021
* master:
  fix 'durable' setting in RabbitMQ (dapr#1183)
  Support setting up Azure IoT Hub for integration testing with EventHubs components (dapr#1174)
  gcp bucket update  (dapr#1128)
  ok-to-test changes for components-contrib (dapr#1091)
  version stored procedure due to previous changes made (dapr#1176)
  Fix existing integration tests (dapr#1173)
  Add state alicloud.tablestore (dapr#1116)
  Add dapr user agent for Azure Components (dapr#1152)
  Support using setup-azure-conf-test.sh with existing Service Principal (dapr#1158)
  Add Event Hubs conformance tests to conformance.yml workflow (dapr#1164)
  restructure code and add comments per code review
  cover all concurrency + etag cases
  Fix EOF linebreaks
  Adds first-write conformance test
  update metadata key
  fix linter warnings
  TableStorage conformance tests pass
  TableStore config
  tablestorage conformance WIP
  ci: standard linter config (dapr#1102)

# Conflicts:
#	secretstores/hashicorp/vault/vault.go
amimimor pushed a commit to amimimor/components-contrib that referenced this pull request Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants