Update setup-azure-conf-test.sh #1213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add removal of AKV_SPAUTH_SP to generated teardown script. - Fix extraction of `clientId` and `clientSecret` from provided credentials without line breaks.
berndverst
approved these changes
Oct 21, 2021
Member
berndverst
left a comment
berndverst
left a comment
There was a problem hiding this comment.
Thanks for adding that. LGTM
Codecov Report
@@ Coverage Diff @@
## master #1213 +/- ##
==========================================
- Coverage 35.07% 35.06% -0.01%
==========================================
Files 147 147
Lines 12624 12624
==========================================
- Hits 4428 4427 -1
- Misses 7727 7729 +2
+ Partials 469 468 -1
Continue to review full report at Codecov.
|
amimimor
pushed a commit
to amimimor/components-contrib
that referenced
this pull request
Dec 9, 2021
Update setup-azure-conf-test.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AKV_SPAUTH_SPto generated teardown script.clientIdandclientSecretfrom provided credentials without line breaks.Issue reference
Extends #1206
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: