Skip to content

Conversation

@berndverst
Copy link
Member

Description

The defer method's proper channel closing for the timer was causing a hang when a timer had correctly completed. This change ensures there will be no hanging.

Issue reference

#1137

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly

@berndverst berndverst requested review from a team as code owners October 27, 2021 02:52
@daixiang0
Copy link
Member

Do you consider abort defer and using channels to control shutdown cases like this?

@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #1237 (f1c0139) into master (426c458) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1237      +/-   ##
==========================================
- Coverage   35.07%   35.04%   -0.04%     
==========================================
  Files         147      147              
  Lines       12747    12747              
==========================================
- Hits         4471     4467       -4     
- Misses       7795     7801       +6     
+ Partials      481      479       -2     
Impacted Files Coverage Δ
state/cloudstate/cloudstate_crdt.go 8.67% <0.00%> (-1.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e373b95...f1c0139. Read the comment docs.

@artursouza artursouza merged commit 07c7a04 into dapr:master Oct 27, 2021
@artursouza artursouza added this to the v1.5 milestone Oct 27, 2021
amimimor pushed a commit to amimimor/components-contrib that referenced this pull request Dec 9, 2021
Co-authored-by: Long Dai <long.dai@intel.com>
Signed-off-by: Amit Mor <amitm@at-bay.com>
amimimor pushed a commit to amimimor/components-contrib that referenced this pull request Dec 9, 2021
Co-authored-by: Long Dai <long.dai@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants