Chore: Remove code duplication for port allocation #1245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #1245 +/- ##
==========================================
- Coverage 34.99% 34.99% -0.01%
==========================================
Files 147 147
Lines 12764 12774 +10
==========================================
+ Hits 4467 4470 +3
- Misses 7818 7830 +12
+ Partials 479 474 -5
Continue to review full report at Codecov.
|
artursouza
approved these changes
Oct 28, 2021
pkedy
reviewed
Oct 28, 2021
| assert.NoError(t, err) | ||
| currentHttpPort, err := network.GetAvailablePort() | ||
| ports, err := dapr_testing.GetFreePorts(2) | ||
| assert.NoError(t, err) |
| assert.NoError(t, err) | ||
| currentHttpPort, err = network.GetAvailablePort() | ||
| ports, err = dapr_testing.GetFreePorts(2) | ||
| assert.NoError(t, err) |
amimimor
pushed a commit
to amimimor/components-contrib
that referenced
this pull request
Dec 9, 2021
…apr#1245) Signed-off-by: Amit Mor <amitm@at-bay.com>
amimimor
pushed a commit
to amimimor/components-contrib
that referenced
this pull request
Dec 9, 2021
…apr#1245) Signed-off-by: Amit Mor <amitm@at-bay.com>
amimimor
pushed a commit
to amimimor/components-contrib
that referenced
this pull request
Dec 9, 2021
…apr#1245) Signed-off-by: Amit Mor <amitm@at-bay.com>
amimimor
pushed a commit
to amimimor/components-contrib
that referenced
this pull request
Dec 9, 2021
…apr#1245) Signed-off-by: Amit Mor <amitm@at-bay.com>
amimimor
pushed a commit
to amimimor/components-contrib
that referenced
this pull request
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes code duplication for port allocation.
Use dapr/dapr/pkg/testing/network instead