Skip to content

Optimize vault secret component error output #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 8, 2021
Merged

Optimize vault secret component error output #909

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
10b81e2
Optimize vault secret component error output
Taction Jun 1, 2021
0421559
Merge branch 'master' into optimize_vault_error
pkedy Jun 16, 2021
d1e233c
add debug log
Taction Jun 17, 2021
4a7f715
fix lint
Taction Jun 17, 2021
e39a0d0
Merge branch 'master' into optimize_vault_error
pkedy Jun 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions secretstores/hashicorp/vault/vault.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,9 +189,10 @@ func (v *vaultSecretStore) getSecret(secret string) (*vaultKVResponse, error) {
if httpresp.StatusCode != 200 {
var b bytes.Buffer
io.Copy(&b, httpresp.Body)
v.logger.Debugf("getSecret %s couldn't get successful response: %#v, %s", secret, httpresp, b.String())

return nil, fmt.Errorf("couldn't to get successful response: %#v, %s",
httpresp, b.String())
return nil, fmt.Errorf("couldn't get successful response, status code %d, body %s",
httpresp.StatusCode, b.String())
}

var d vaultKVResponse
Expand Down Expand Up @@ -252,9 +253,10 @@ func (v *vaultSecretStore) BulkGetSecret(req secretstores.BulkGetSecretRequest)
if httpresp.StatusCode != 200 {
var b bytes.Buffer
io.Copy(&b, httpresp.Body)
v.logger.Debugf("list keys couldn't get successful response: %#v, %s", httpresp, b.String())

return secretstores.BulkGetSecretResponse{Data: nil}, fmt.Errorf("couldn't get successful response: %#v, %s",
httpresp, b.String())
return secretstores.BulkGetSecretResponse{Data: nil}, fmt.Errorf("list keys couldn't get successful response, status code %d, body %s",
httpresp.StatusCode, b.String())
}

var d vaultListKVResponse
Expand Down