Skip to content

Conversation

@hokandil
Copy link
Contributor

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Issue reference

@greenie-msft
Copy link
Contributor

dapr/dapr PR: dapr/dapr#3751
components-contrib PR: dapr/components-contrib#885

title: "Azure CosmosGraphDB binding spec"
linkTitle: "Azure CosmosGraphDB"
description: "Detailed documentation on the Azure CosmosGraphDB binding component"
aliases:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hokandil Is there a reason why this page needs an alias? If not, can you please remove it?

|------|:----------------:|:-----------------:|--------| --------- | ---------- |
| [Azure Blob Storage]({{< ref blobstorage.md >}}) | || Alpha | v1 | 1.0 |
| [Azure CosmosDB]({{< ref cosmosdb.md >}}) | || Alpha | v1 | 1.0 |
| [Azure CosmosGraphDB]({{< ref cosmosgrapdb.md >}}) | || Alpha | v1 | 1.5 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hokandil, it also looks like you misspelled the linked file "cosmosgrapdb.md" should be read "cosmosdbgraph.md"

@msfussell
Copy link
Member

@hokandil - We will need you to change the name of the component in the next day per @greenie-msft if this is going into the v1.5 release for next week. Otherwise this will be moved the the v1.6 release in Jan.

@hokandil
Copy link
Contributor Author

hokandil commented Nov 4, 2021

@msfussell I will do my best

@hokandil hokandil changed the title Add content for Azure CosmosDB Graph dapr#1849 V1.5 Add content for Azure CosmosDBGremlinAPI dapr#1849 V1.5 Nov 4, 2021
@hokandil
Copy link
Contributor Author

hokandil commented Nov 4, 2021

@greenie-msft @msfussell I changed the components-contrib , dapr and Docs

@greenie-msft greenie-msft merged commit 69ca494 into dapr:v1.5 Nov 4, 2021
@greenie-msft
Copy link
Contributor

@hokandil Thank you for your contributions! This will go into the v1.5 release!

@hokandil
Copy link
Contributor Author

hokandil commented Nov 4, 2021

Thank you @greenie-msft , it was a good time celebrating my birthday today 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants