Skip to content

Conversation

@jukhancisco
Copy link

@jukhancisco jukhancisco commented Nov 3, 2025

Summary

This PR clarifies the documentation for the dapr.io/max-body-size annotation to explicitly state that it applies to both request and response bodies, not just incoming requests.

Target: v1.16 documentation (for Dapr v1.16.3 release)

Changes

Updated the max-body-size annotation description in the arguments and annotations reference to clarify that it applies to:

  • Incoming HTTP/gRPC requests to the Dapr sidecar
  • Actor operation responses
  • Binding component responses (added in Dapr v1.16.3)

Previous Description

Inreasing the request max body size to handle large file uploads using http and grpc protocols. Set the value using size units (e.g., 16Mi for 16MB). The default is 4Mi

New Description

Maximum size for HTTP/gRPC request and response bodies. Applies to incoming requests to the Dapr sidecar, actor operations, and binding component responses. Useful for handling large file uploads/downloads. Set the value using size units (e.g., 16Mi for 16MB). The default is 4Mi. Note: Binding component response size enforcement added in Dapr v1.16.3.

Why This Change?

Users were confused about the scope of the max-body-size annotation. The fix in PR dapr/dapr#9151 (targeting v1.16.3) ensures binding components also respect this annotation, fixing issue dapr/dapr#9177.

This documentation update helps users understand:

  1. The annotation controls both requests AND responses
  2. It applies to binding component responses (as of v1.16.3)
  3. It's useful for both uploads and downloads

Related Issues/PRs

Checklist

  • Updated annotation description for v1.16 docs
  • Referenced the version where binding support was added (v1.16.3)
  • Clarified scope (requests + responses)
  • Linked related issues/PRs
  • Targeted v1.16 documentation branch

Updated the max-body-size annotation description to clarify that it applies to:
- Incoming HTTP/gRPC requests to the Dapr sidecar
- Actor operation responses
- Binding component responses (added in v1.16.2)

This clarification helps users understand that the annotation controls
both request and response body sizes, not just incoming requests.

Fixes: dapr/components-contrib#4076
Related: dapr/dapr#9151
Signed-off-by: Junaid Khan <jukhan@cisco.com>
@jukhancisco jukhancisco force-pushed the docs/clarify-max-body-size-annotation branch from 85d6601 to 50225c0 Compare November 3, 2025 15:57
jukhancisco and others added 2 commits November 7, 2025 08:05
The binding component response size enforcement fix is now targeting
v1.16.3 release instead of v1.16.2 (which was already released).

Updated the annotation documentation to reflect the correct version.

Signed-off-by: Junaid Khan <jukhan@cisco.com>
@jukhancisco jukhancisco changed the title docs: Clarify max-body-size applies to requests and responses (v1.16) docs: Clarify max-body-size applies to requests and responses (v1.16.3) Nov 10, 2025
@cicoyle cicoyle added the waiting-on-code-pr The code PR needs to be merged before the docs are updated label Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-on-code-pr The code PR needs to be merged before the docs are updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minio Binding Fails to Fetch Files Larger Than 4MB Despite dapr.io/max-body-size Annotation

3 participants