Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose underlying gRPC client and server objects #311

Merged
merged 5 commits into from
Sep 30, 2022

Conversation

ItalyPaleAle
Copy link
Contributor

Allows using the gRPC server and client connection for other purposes as needed.

Fixes #204

Fixes dapr#204

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
@ItalyPaleAle ItalyPaleAle requested a review from a team as a code owner August 8, 2022 18:21
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #311 (fe811ab) into main (f182441) will decrease coverage by 0.22%.
The diff coverage is 65.00%.

@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
- Coverage   68.00%   67.78%   -0.23%     
==========================================
  Files          29       29              
  Lines        1566     1577      +11     
==========================================
+ Hits         1065     1069       +4     
- Misses        413      419       +6     
- Partials       88       89       +1     
Impacted Files Coverage Δ
client/client.go 72.72% <50.00%> (-1.30%) ⬇️
service/grpc/service.go 57.14% <66.66%> (-5.36%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@yaron2
Copy link
Member

yaron2 commented Sep 30, 2022

@ItalyPaleAle please resolve conflicts.

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
@ItalyPaleAle
Copy link
Contributor Author

@yaron2 done

@yaron2 yaron2 merged commit cfd7483 into dapr:main Sep 30, 2022
@ItalyPaleAle ItalyPaleAle deleted the expose-grpc branch October 3, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose underlying grpc client
2 participants