From 5d1a1a9f2fe7455bec86e0cbe77d34e0f7db7195 Mon Sep 17 00:00:00 2001 From: Deepak Date: Wed, 21 May 2025 03:19:32 +0530 Subject: [PATCH 1/2] Fix Typo in Comments Signed-off-by: Deepak --- .../src/main/java/io/dapr/examples/DaprApplication.java | 2 +- .../main/java/io/dapr/actors/client/ActorProxyImpl.java | 2 +- .../src/test/java/io/dapr/it/actors/ActorStateIT.java | 2 +- .../test/java/io/dapr/it/state/AbstractStateClientIT.java | 8 ++++---- sdk/src/main/java/io/dapr/client/DaprClientBuilder.java | 2 +- sdk/src/main/java/io/dapr/client/DaprClientImpl.java | 2 +- sdk/src/main/java/io/dapr/client/domain/State.java | 2 +- sdk/src/test/java/io/dapr/client/DaprClientGrpcTest.java | 2 +- sdk/src/test/java/io/dapr/utils/NetworkUtilsTest.java | 2 +- spring-boot-examples/kubernetes/kind-with-registry.sh | 2 +- 10 files changed, 13 insertions(+), 13 deletions(-) diff --git a/examples/src/main/java/io/dapr/examples/DaprApplication.java b/examples/src/main/java/io/dapr/examples/DaprApplication.java index 3b9657f0cd..10f56d2194 100644 --- a/examples/src/main/java/io/dapr/examples/DaprApplication.java +++ b/examples/src/main/java/io/dapr/examples/DaprApplication.java @@ -23,7 +23,7 @@ public class DaprApplication { /** - * Starts Dapr's callback in a given port and specified protocal. + * Starts Dapr's callback in a given port and specified protocol. * * @param port Port to listen to. * @param protocal select Http or gRPC to run. diff --git a/sdk-actors/src/main/java/io/dapr/actors/client/ActorProxyImpl.java b/sdk-actors/src/main/java/io/dapr/actors/client/ActorProxyImpl.java index d5a159d5fe..93acc62089 100644 --- a/sdk-actors/src/main/java/io/dapr/actors/client/ActorProxyImpl.java +++ b/sdk-actors/src/main/java/io/dapr/actors/client/ActorProxyImpl.java @@ -42,7 +42,7 @@ class ActorProxyImpl implements ActorProxy, InvocationHandler { private final String actorType; /** - * Serializer/deserialzier to exchange message for Actors. + * Serializer/deserializer to exchange message for Actors. */ private final DaprObjectSerializer serializer; diff --git a/sdk-tests/src/test/java/io/dapr/it/actors/ActorStateIT.java b/sdk-tests/src/test/java/io/dapr/it/actors/ActorStateIT.java index 90bab85e52..ffd5d3c3dd 100644 --- a/sdk-tests/src/test/java/io/dapr/it/actors/ActorStateIT.java +++ b/sdk-tests/src/test/java/io/dapr/it/actors/ActorStateIT.java @@ -55,7 +55,7 @@ public void writeReadState() throws Exception { new ActorProxyBuilder(actorType, ActorProxy.class, deferClose(run.newActorClient())); ActorProxy proxy = proxyBuilder.build(actorId); - // wating for actor to be activated + // waiting for actor to be activated Thread.sleep(5000); // Validate conditional read works. diff --git a/sdk-tests/src/test/java/io/dapr/it/state/AbstractStateClientIT.java b/sdk-tests/src/test/java/io/dapr/it/state/AbstractStateClientIT.java index 60a5c51b95..255c310517 100644 --- a/sdk-tests/src/test/java/io/dapr/it/state/AbstractStateClientIT.java +++ b/sdk-tests/src/test/java/io/dapr/it/state/AbstractStateClientIT.java @@ -331,7 +331,7 @@ public void saveUpdateAndGetStateWithEtag() { response = daprClient.getState(STATE_STORE_NAME, new State<>(stateKey, (MyData) null, null), MyData.class); - //retrive the data wihout any etag + //retrieve the data without any etag myDataResponse = response.block(); //review that state value changes @@ -509,7 +509,7 @@ public void saveAndDeleteStateWithWrongEtag() { public void saveUpdateAndGetStateWithEtagAndStateOptionsFirstWrite() { final String stateKey = "keyToBeUpdatedWithEtagAndOptions"; - //create option with concurrency with first writte and consistency of strong + //create option with concurrency with first write and consistency of strong StateOptions stateOptions = new StateOptions(StateOptions.Consistency.STRONG, StateOptions.Concurrency.FIRST_WRITE); @@ -571,7 +571,7 @@ public void saveUpdateAndGetStateWithEtagAndStateOptionsFirstWrite() { public void saveUpdateAndGetStateWithEtagAndStateOptionsLastWrite() { final String stateKey = "keyToBeUpdatedWithEtagAndOptions"; - //create option with concurrency with first writte and consistency of strong + //create option with concurrency with first write and consistency of strong StateOptions stateOptions = new StateOptions(StateOptions.Consistency.STRONG, StateOptions.Concurrency.LAST_WRITE); //create dapr client @@ -599,7 +599,7 @@ public void saveUpdateAndGetStateWithEtagAndStateOptionsLastWrite() { assertEquals("data in property A", myDataResponse.getValue().getPropertyA()); assertEquals("data in property B", myDataResponse.getValue().getPropertyB()); - //change data to be udpated + //change data to be updated data.setPropertyA("data in property A2"); data.setPropertyB("data in property B2"); //create deferred action to update the action with options diff --git a/sdk/src/main/java/io/dapr/client/DaprClientBuilder.java b/sdk/src/main/java/io/dapr/client/DaprClientBuilder.java index abb6b8524f..14789efcd4 100644 --- a/sdk/src/main/java/io/dapr/client/DaprClientBuilder.java +++ b/sdk/src/main/java/io/dapr/client/DaprClientBuilder.java @@ -156,7 +156,7 @@ public DaprPreviewClient buildPreviewClient() { } /** - * Creates an instance of the GPRC Client. + * Creates an instance of the GRPC Client. * * @return the GRPC Client. * @throws java.lang.IllegalStateException if either host is missing or if port is missing or a negative number. diff --git a/sdk/src/main/java/io/dapr/client/DaprClientImpl.java b/sdk/src/main/java/io/dapr/client/DaprClientImpl.java index 66c8772d66..d515cf0fcc 100644 --- a/sdk/src/main/java/io/dapr/client/DaprClientImpl.java +++ b/sdk/src/main/java/io/dapr/client/DaprClientImpl.java @@ -146,7 +146,7 @@ public class DaprClientImpl extends AbstractDaprClient { private final DaprGrpc.DaprStub asyncStub; /** - * The HTTP client to be used for healthz and HTTP service invocation only. + * The HTTP client to be used for health and HTTP service invocation only. * * @see io.dapr.client.DaprHttp */ diff --git a/sdk/src/main/java/io/dapr/client/domain/State.java b/sdk/src/main/java/io/dapr/client/domain/State.java index ae087d9869..3382e843b3 100644 --- a/sdk/src/main/java/io/dapr/client/domain/State.java +++ b/sdk/src/main/java/io/dapr/client/domain/State.java @@ -17,7 +17,7 @@ import java.util.Map; /** - * This class reprent what a State is. + * This class represents what a State is. * * @param The type of the value of the sate */ diff --git a/sdk/src/test/java/io/dapr/client/DaprClientGrpcTest.java b/sdk/src/test/java/io/dapr/client/DaprClientGrpcTest.java index 336f205353..54240d70ca 100644 --- a/sdk/src/test/java/io/dapr/client/DaprClientGrpcTest.java +++ b/sdk/src/test/java/io/dapr/client/DaprClientGrpcTest.java @@ -1365,7 +1365,7 @@ private State buildStateKey(T value, String key, String etag, MapThis test will execute the following flow:

*
    - *
  1. Exeucte client getState for Key=key1
    2. + *
  2. Execute client getState for Key=key1
    3. *
  3. Block for result to the the state
    4. *
  4. Assert the Returned State is the expected to key1
    5. *
  5. Execute client getState for Key=key2
    6. diff --git a/sdk/src/test/java/io/dapr/utils/NetworkUtilsTest.java b/sdk/src/test/java/io/dapr/utils/NetworkUtilsTest.java index 2b4929abd0..f4428007ad 100644 --- a/sdk/src/test/java/io/dapr/utils/NetworkUtilsTest.java +++ b/sdk/src/test/java/io/dapr/utils/NetworkUtilsTest.java @@ -7,7 +7,7 @@ * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the sppecific language governing permissions and + * See the License for the specific language governing permissions and limitations under the License. */ diff --git a/spring-boot-examples/kubernetes/kind-with-registry.sh b/spring-boot-examples/kubernetes/kind-with-registry.sh index 78a8692a17..6bb8b1315a 100755 --- a/spring-boot-examples/kubernetes/kind-with-registry.sh +++ b/spring-boot-examples/kubernetes/kind-with-registry.sh @@ -14,7 +14,7 @@ fi # # NOTE: the containerd config patch is not necessary with images from kind v0.27.0+ # It may enable some older images to work similarly. -# If you're only supporting newer relases, you can just use `kind create cluster` here. +# If you're only supporting newer releases, you can just use `kind create cluster` here. # # See: # https://github.com/kubernetes-sigs/kind/issues/2875 From beffa086017fe69758edb56b00f549c409a4f2a7 Mon Sep 17 00:00:00 2001 From: Deepak Date: Wed, 21 May 2025 07:05:47 +0530 Subject: [PATCH 2/2] Update review comments Signed-off-by: Deepak --- sdk/src/main/java/io/dapr/client/DaprClientImpl.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/src/main/java/io/dapr/client/DaprClientImpl.java b/sdk/src/main/java/io/dapr/client/DaprClientImpl.java index d515cf0fcc..66c8772d66 100644 --- a/sdk/src/main/java/io/dapr/client/DaprClientImpl.java +++ b/sdk/src/main/java/io/dapr/client/DaprClientImpl.java @@ -146,7 +146,7 @@ public class DaprClientImpl extends AbstractDaprClient { private final DaprGrpc.DaprStub asyncStub; /** - * The HTTP client to be used for health and HTTP service invocation only. + * The HTTP client to be used for healthz and HTTP service invocation only. * * @see io.dapr.client.DaprHttp */