Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add log to see if ctx is replay and the log returned by ctx.getLogger() #989

Closed
wants to merge 5 commits into from

Conversation

skyao
Copy link
Member

@skyao skyao commented Jan 15, 2024

Description

Verify the bug mentioned in issue:

#988

Issue reference

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@skyao skyao requested review from a team as code owners January 15, 2024 05:27
skyao added 4 commits January 15, 2024 13:27
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4a7b985) 77.31% compared to head (34bef53) 77.31%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #989   +/-   ##
=========================================
  Coverage     77.31%   77.31%           
  Complexity     1537     1537           
=========================================
  Files           143      143           
  Lines          4642     4642           
  Branches        541      541           
=========================================
  Hits           3589     3589           
  Misses          778      778           
  Partials        275      275           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skyao
Copy link
Member Author

skyao commented Jan 15, 2024

Found it!

See:

#975 (comment)

Close this verify PR.

@skyao skyao closed this Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant